[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 6/8] AMD/IOMMU: provide function backing XENMEM_reserved_device_memory_map


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 26 Aug 2021 14:24:02 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZeJkFxSlzPeDM7f7FnTgprzWkvtBwvtmqGpMRyUuHQ=; b=nbOLPApdwUK1X8mZ0hq2ZteGzAVgDIwEia9BgcvtXir6xjDCjdukVPOYBu8UzmwhBorb8CV/gwlGI59huDo9Dd9z/kO1DrKcNP5oIyVw3bEOE/qwTFsGVGSBrIViyAv4CN5WpxKM2tGRayByoHN5B5idHLtIRlaQFOOEJpqMPymFht17IAXeS3ZIn3UTjQvjv/oJd5giYYnjzlaRewCxsFwICrLkUWi9Gqg3QlkjNqPEhw7iwVfPNP3I0FnBNkZtKluLVWjCeTyFCN4zHi9ZvnuNwWCBn7HbbxZWby1j+HT1JecRgaqbHXqC7P6/Lzv7TkZbs+Y9MZSdwiCH1V7LQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dg3IRAneYPm515NqXe+KEsg1hF0JY/vD/OH8ar1EMRGb2/rtoT6Aan983XQEEX/GpQf+Veg/BjHlIZTpCyUwF794+R4bsBVz7UxP4AhTRt32hEgp8K+VQwIoSHrbrmDcUa3wncg6pkTmA8JN12DSbwKrBZ1wGjooUh4b4R22EilKB1W6UD4TjT9JCAQMZDiwggDqpZud5Sn4k6+xblcT7IVK/DdQhlADHyD6vnA6IxEgCSX09rim33xG0b4RmBrt4pOywkuPsEhQYm1akqcFLPgVBa/ro6lt8Xh6+PlPZnoHanJdQu7F1DSJkcvJydh9ysNvLnoWWvehSj/DcMJfYg==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Thu, 26 Aug 2021 13:24:17 +0000
  • Ironport-hdrordr: A9a23:bFlkZq9Fu27QGOi9tqtuk+DoI+orL9Y04lQ7vn2ZLiY4TiX4ra +TdZEgviMc5wx+ZJhNo7G90cu7MBDhHO9OgbX5VI3KNGOKhILPFvAG0WKI+UyDJ8SRzJ866Y 5QN4R4Fd3sHRxboK/BkXCF+g8bsb26GXaT9IDj80s=
  • Ironport-sdr: ZcjzxEOmssStl9hjzjA7avjt77X1aLCb4QC1j3DgCGUL92oE+Qf1rf7im3DkRaiUmEOIRc3pPi Rcv5pz5HeFSkXfQ4Z9HaX3RPtbA2ml+iicp9C5ud60wIAxJz0j2R+FAl5o0K36LYd2WHygj8Nz WFE6gqk/FvHmyFq/p3YMdrRzdfnAhY8PoXU+Qd7dYoZVygpDZ0XocDbqX59/3Lv2YjiKSm3VSm LHgAhsiVN+nW7qsNM2N9oEe/dJWBKJ4LOTQZhjUUokmhtWzIRJtuNFeY9G2VOt7vlcHJ1phWVI jYZUqCUeCcXFfeS5/toUZGhq
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/08/2021 08:25, Jan Beulich wrote:
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -467,6 +467,81 @@ int amd_iommu_reserve_domain_unity_unmap
>      return rc;
>  }
>  
> +int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
> +{
> +    unsigned int seg = 0 /* XXX */, bdf;

Is this XXX intended to stay?

I can't say I'm fussed about multi-segment handling, given the absence
of support on any hardware I've ever encountered.

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.