[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 6/8] AMD/IOMMU: provide function backing XENMEM_reserved_device_memory_map
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Aug 2021 16:05:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3VPyvXcf4IjnTUJ74MZhwOXd4X4XWnIhck2OGPmmw6M=; b=j5a7OJHkZREM9nZCtvZfnyx7NAGGmi/gnda5J+z2abewPvRzqjyPKDk1ZBzDCLPZWO113WpKNqBXiBEJcm1VKCwY8QMl4ogk7v23fpNXbsWXr63v82X7PeVtko/+tPR8NI0YCcAFT+SPppHeY9mPrDcUvlBqnGp5RlCRf1VkJAUTqR6RBlMDtMliRhCi72F4BzQZX0W2Qr+dOKs+O4qcV5ToC16+v/qiDJVbC31lQ/mM20cQeTs/SulQiDirjbXTNYBZSpbZSk0nLvOaSktMD6hAYYZ4rv29ee0SuOXn5/Fedp/rZQ2+6xsJ9Dz2eSD0C6RrtsD+O8/rHt7bGxyxrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwR/QYkzu7k9WwyKxdoSkMeJPGCOgVTznU6168RMzMpLNlqFuAfEBx34RdaRquq7YKmH4st8loVPyHZrYH4i2MqXHRLvGpUs99KEfZdCTEfm/H5aSozr6MTL4Hf962jiHQHjRbMMJm/X/5ttIjTa6P7QetqFMRkDJ5+7qFJQFNXZl0Fcf9pHrarn+kI/M8Irz9Z55INwqRnhx9Zcf8lyvXr+1p4scaSks58n0R6JFTKji7RtCjX9+hLsfOqtZUWquLgazxYVK7H1noYNY81bjAsDmiu5S4KjYnrk9ZmpgvPUZIM/O8rnbF06xX83PofZxYGKkhxzm9xon97enagc6w==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 26 Aug 2021 14:06:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.08.2021 15:24, Andrew Cooper wrote:
> On 26/08/2021 08:25, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>> @@ -467,6 +467,81 @@ int amd_iommu_reserve_domain_unity_unmap
>> return rc;
>> }
>>
>> +int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
>> +{
>> + unsigned int seg = 0 /* XXX */, bdf;
>
> Is this XXX intended to stay?
Yes - we've already got 3 similar instances plus at least two where the
hardcoding of segment 0 is not otherwise marked.
Jan
> I can't say I'm fussed about multi-segment handling, given the absence
> of support on any hardware I've ever encountered.
>
> ~Andrew
>
|
