[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V4 04/13] hyperv: Mark vmbus ring buffer visible to host in Isolation VM

Hi Greg:
     Thanks for your review.

On 8/28/2021 1:41 AM, Greg KH wrote:
On Fri, Aug 27, 2021 at 01:21:02PM -0400, Tianyu Lan wrote:
From: Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx>

Mark vmbus ring buffer visible with set_memory_decrypted() when
establish gpadl handle.

Signed-off-by: Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx>
Change since v3:
        * Change vmbus_teardown_gpadl() parameter and put gpadl handle,
        buffer and buffer size in the struct vmbus_gpadl.
  drivers/hv/channel.c            | 36 ++++++++++++++++++++++++++++-----
  drivers/net/hyperv/hyperv_net.h |  1 +
  drivers/net/hyperv/netvsc.c     | 16 +++++++++++----
  drivers/uio/uio_hv_generic.c    | 14 +++++++++++--
  include/linux/hyperv.h          |  8 +++++++-
  5 files changed, 63 insertions(+), 12 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index f3761c73b074..82650beb3af0 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -17,6 +17,7 @@
  #include <linux/hyperv.h>
  #include <linux/uio.h>
  #include <linux/interrupt.h>
+#include <linux/set_memory.h>
  #include <asm/page.h>
  #include <asm/mshyperv.h>
@@ -474,6 +475,13 @@ static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
        if (ret)
                return ret;
+ ret = set_memory_decrypted((unsigned long)kbuffer,
+                                  HVPFN_UP(size));
+       if (ret) {
+               pr_warn("Failed to set host visibility for new GPADL %d.\n", 

dev_warn()?  You have access to a struct device, why not use it?

same for all other instances here.

Yes, dav_warn() is better. Will update in the next version. Thanks.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.