[ovmf test] 164686: regressions - FAIL

[osstest service owner <osstest-admin@xxxxxxxxxxxxxx>]

flight 164686 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/164686/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 164674
 build-amd64-xsm               6 xen-build                fail REGR. vs. 164674
 build-i386-xsm                6 xen-build                fail REGR. vs. 164674
 build-i386                    6 xen-build                fail REGR. vs. 164674

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9f3eda177a4b2d4a33ff1b0307cad42906396562
baseline version:
 ovmf                 cae735f61328d64e2e8991036707b9e78c0f5f63

Last test of basis   164674  2021-08-31 02:56:52 Z    1 days
Testing same since   164686  2021-09-01 03:03:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@xxxxxxxxxx>
  Gary Lin <gary.lin@xxxxxxx>
  Jim Fehlig <jfehlig@xxxxxxxx>
  Lin, Gary (HPS OE-Linux) <gary.lin@xxxxxxx>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 9f3eda177a4b2d4a33ff1b0307cad42906396562
Author: Lin, Gary (HPS OE-Linux) <gary.lin@xxxxxxx>
Date:   Tue Aug 31 09:29:48 2021 +0800

    OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
    
    Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
    the kernel, initrd, and kernel command line from QEMU's fw_cfg.
    
    Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574
    Signed-off-by: Gary Lin <gary.lin@xxxxxxx>
    Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Reviewed-by: Philippe Mathieu-Daude <philmd@xxxxxxxxxx>
    Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
    Tested-by: Jim Fehlig <jfehlig@xxxxxxxx>

commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7
Author: Lin, Gary (HPS OE-Linux) <gary.lin@xxxxxxx>
Date:   Tue Aug 31 09:31:15 2021 +0800

    OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
    
    To avoid the potential inconsistency between PcdAcpiS3Enable and
    QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect
    S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do.
    
    Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
    Signed-off-by: Gary Lin <gary.lin@xxxxxxx>
    Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
    Reviewed-by: Jiewen Yao <Jiewen.yao@xxxxxxxxx>
    Tested-by: Jim Fehlig <jfehlig@xxxxxxxx>

commit 52e2dabc0f8d3af09c213072ce8ba734302f585d
Author: Lin, Gary (HPS OE-Linux) <gary.lin@xxxxxxx>
Date:   Tue Aug 31 09:31:14 2021 +0800

    OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support
    
    To avoid the potential inconsistency between PcdAcpiS3Enable and
    QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to
    detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do.
    
    Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
    Signed-off-by: Gary Lin <gary.lin@xxxxxxx>
    Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
    Reviewed-by: Jiewen Yao <Jiewen.yao@xxxxxxxxx>
    Tested-by: Jim Fehlig <jfehlig@xxxxxxxx>

commit 28152333bccb778b62e6e97446b28bfa0e92ef82
Author: Lin, Gary (HPS OE-Linux) <gary.lin@xxxxxxx>
Date:   Tue Aug 31 09:31:13 2021 +0800

    OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
    
    To avoid the potential inconsistency between PcdAcpiS3Enable and
    QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect
    S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do.
    
    Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
    Signed-off-by: Gary Lin <gary.lin@xxxxxxx>
    Reviewed-by: Philippe Mathieu-Daude <philmd@xxxxxxxxxx>
    Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
    Reviewed-by: Jiewen Yao <Jiewen.yao@xxxxxxxxx>
    Tested-by: Jim Fehlig <jfehlig@xxxxxxxx>

commit cb0d24637dfdd869618b9635dfb8e3b0746393a6
Author: Lin, Gary (HPS OE-Linux) <gary.lin@xxxxxxx>
Date:   Tue Aug 31 09:31:12 2021 +0800

    OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
    
    There are several functions in OvmfPkg/Library using
    QemuFwCfgS3Enabled() to detect the S3 support status. However, in
    MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since
    InitializeXenPlatform() didn't set PcdAcpiS3Enable as
    InitializePlatform() did, this made the inconsistency between
    drivers/functions.
    
    For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped
    S3BootScript because the default value is FALSE. On the other hand,
    PlatformBootManagerBeforeConsole() from OvmfPkg/Library called
    QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked
    SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so
    SaveS3BootScript() asserted due to EFI_NOT_FOUND.
    
    This issue mainly affects "HVM Direct Kernel Boot". When used,
    "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in
    that case.
    
    Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
    Signed-off-by: Gary Lin <gary.lin@xxxxxxx>
    Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
    Reviewed-by: Jiewen Yao <Jiewen.yao@xxxxxxxxx>
    Tested-by: Jim Fehlig <jfehlig@xxxxxxxx>