[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Sep 2021 08:14:14 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lE+pv+2t6gwcK6U4MSVYO6DoEvX4rlBIfkZVESIv7zc=; b=TPd7QSzH3Xrhv5V4PAzNTasoHSu8826fko0zq4zmw8nIMTcMlAyFMLkTK356baQx6KgrDveeLh4Ril1q2FTeUEJJX5sQYJXRsV+N/4dtXjhxt1pf0U8LYjMpqMT2+djFN5P7tcUT2vVDszXiPIYFf8wKx0UTvo4ReH0KGYLIK+9T11f13AUXzIzB3FQrjaBnLSmPR2ANiyrqjBiEwHrlJR6tL9HqEriQp2x+l7PxQEqFXuiHLjPNLcb8vP+Aoh8AGyLuTMi6QXbfQHtSIkKHtSKDdX+bVrLW8PTskg82ALf+d/tR8Ipf/YSm6iVSLXKO9eo9jP0y2AkyalLgcU6NSA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hr3DKHK7A9LutM5P9cRMQIn50PlzDY+ZN17mvsB1JAqyMRB1K3u90/sLb4BAVYUrq/cZjr2GCSKjGh4/B62LseCj6HHJ9TCYdjXjSjbFoZfW50d5uzJtbl8qRp2azfeP5zEv/mHSMF0Cfxl8IFhJcg32O7PdFRTsbmB+xrzSocsEvVFp7naLprZDYRVVhGR4G4NXlClc+bIjjSmU4932se8LXS/oGvp4K/x6COdrb8j9wk3663uVNoTrOzz9gSjmP3PGaWRZIsUR8vukObQUk/sDBWrNaQmdrnmN9TJ6Tx/VIA530eBxaTMSm+5iFtrId14CwxRWQs5frSUWs8JufA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 07 Sep 2021 06:14:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.08.2021 12:49, Anthony PERARD wrote:
> This replace the use of a single .c file use for multiple .o file by
> creating multiple .c file including the first one.
> There's quite a few issues with trying to build more than one object
> file from a single source file: there's is a duplication of the make
> rules to generate those targets; there is an additional ".file" symbol
> added in order to differentiate between the object files; and the
> tools/symbols have an heuristic to try to pick up the right ".file".
> This patch adds new .c source file which avoid the need to add a
> second ".file" symbol and thus avoid the need to deal with those
> issues.
> Also remove __OBJECT_FILE__ from $(CC) command line as it isn't used
> anywhere anymore. And remove the macro "build-intermediate" since the
> generic rules for single targets can be used.
> And rename the objects in mm/hap/ to remove the extra "level".
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one
already. I'd like to restrict it some: It should be taken to stand for
the technical correctness of the change. Nevertheless I'm not really
happy with the introduction of the various tiny source files. I've
meanwhile been wondering: Can't these be generated (in the build tree,
as soon as that's possible to be separate) rather than getting put in
the repo?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.