[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build!

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Sep 2021 08:20:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TSFfFqofenQbMlBfkKFanf9ysGnmn1I9sU3PxpTZ6YM=; b=DoZNcrW0AKbLpwpZhBnfeScXCMMbfylW0e0JiTecqpKji29aL0eNqiTp7Gj6vdomVUfPnsGZaSBLMqTB7aY7bAwzI54WQUxRmTi6x+WHEjbOA2SIPTobapef5q4MCbVJfzbNg6KtDKvYuNpb+X7+E3DoYA/rNKZ/aw4J0JgIzdidiEMoo2hegY+sis44o34HEhyys/6SF81oJNfyhXwuSK9b0uDJ8pxHHy2AabrOHOa/tTUtscsqMduUhEac/YmpV2tsz9SB7aVMYP7VGCmgHIt2glMcaQv5ZHqP9DOG6j08/bphzAGExP6cG3j5qfj9c6xJoXIStTNfocIHyahIdw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PTpj4yYzUJYGIZnUY8JOmKpSLkb4CFZSAEteaYSVJJfw5W6a87NlYpB+5CKP9eeng++dJYux5BROo6iXNZv249NLbee233dRCsorY1sTYpc6+4x6sDL2QtAhjYQMdueuL6UvU9Q/vlsDHvOXs9bECVIykE2n4dzO6sDGCdBEoDE1Mp5DqqotERzHz49L5E4BYk1OFI5aK1BFaEY9r4o7RU8wlcnq/ruF7MvC9eUc0C4DXLb9pkVgqHOlJbK0yxqAT8hNNYcFXpvNjoFXK8IBjD1krcLcynidS2BLGAeoago+fkGhyW6G+0LYjsLOuHXzrZtfQFutFjDAFsRYf/J1Iw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 07 Sep 2021 06:20:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.09.2021 18:13, Anthony PERARD wrote:
> I hope this is useful:
> On Tue, Aug 24, 2021 at 11:49:47AM +0100, Anthony PERARD wrote:
>> Anthony PERARD (51):
>>   build: introduce cpp_flags macro
>>   build: use if_changed on built_in.o
>>   build: use if_changed_rules with %.o:%.c targets
> all 3 ready to commit
>>   build: factorise generation of the linker scripts
> may need a ack from arm maintainers, does it? Otherwise, ready.

Ah yes. Will need to wait. Which is the first place pointing out that
you answer my question only partly: Does "ready to commit" include
"independent of earlier patches in this series"? Same e.g. ...

>>   x86/mm: avoid building multiple .o from a single .c file
>>   build,include: rework compat-build-source.py
>>   build,include: rework compat-build-header.py
>>   build: fix clean targets when subdir-y is used
>>   build: use subdir-y in test/Makefile
> all 5 ready to commit

... here: In my reply to this cover letter I did specifically that
I've skipped patch 5. As said in a reply just sent there, when writing
that I didn't realize I had already given R-b for it.

I intend to put in some of this series in a couple of minutes; I'll
try to judge what is okay to commit independent of earlier skipped

Thanks for the summary nevertheless,

>>   build,arm: move LDFLAGS change to arch.mk
> need edit commit description, but otherwise ready
>     not needed before [PATCH 21/51] build: set ALL_OBJS to main Makefile; 
> move prelink.o to main Makefile
>>   build: move make option changes check earlier
>>   build: avoid building arm/arm/*/head.o twice
> both ready
> So up to here (12/51) all patch seems to be ready to commit.
>>   build: convert binfile use to if_changed
>>   xen: move include/asm-* to arch/*/include/asm
> both need a ack
>>   build,riscv: tell the build system about riscv64/head.S
> patch ready
> but depends on "[PATCH 14/51] xen: move include/asm-* to arch/*/include/asm"
>     for the rune written in the commit message to work.
>>   build: generate "include/xen/compile.h" with if_changed
>>   build: set XEN_BUILD_EFI earlier
>>   build: fix $(TARGET).efi creation in arch/arm
> patches needs review
>>   build: fix arch/x86/note.o rule
> ready, standalone
> The rest of the series needs review.
> Cheers,



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.