[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 08/12] swiotlb-xen: arrange to have buffer info logged


  • To: Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Sep 2021 14:07:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n7mzpWDSKQyeB1Y7K6PB6/ey7zolLxcOfxP5VRC4xpg=; b=bncueqn56HBLtcSH4vHgtaTxs9jKY+re9pppPYPvwbY4YDfvfW6CztYMvYRehgdwJm+YeuRjF0/y9b/kURFHgknYzLDHx1eYCTWmkrd9srrvXilKQIQI0hMH2Z0Yy1ANZo51f77VNnCNZS2p9CDgbP2m0ImH07hJFBtgxUnyOnpK6r3PhuXXV/WgCLAm5ettm1nm1vudbQ+GDSrBPOYlxALXuDiAYgxlcCNH3Q0cllH6xTyFwlCR66dG1heQVXIuOAt63n22daKJhdmYCaxZY3srkXpYSvqdCeym07RAkvGUMU77E6gjpmoiAUoIE5IFKdw7yYSRtAXn5hFNysynwA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTIxY8KEDICOriuKX5SuLtaLX8doPexdNM9CYmFxBEanU/cMmnEH74KVzYL39rSFD4cTK9jSwCf4ro+4qMbDkqqBLCOfMNGCux8PMyFvz+3NkZ/exWTw03IZyKMARPSGHmzocZ+YFv8HHvBAAwuxxZbO8mABTODP4EP5WWfk48N/foFbOGqUk0zrhDI3RhKPTgkV79ysNrU+2aYboDr/x9c27H5xTUK3hSOjV8HqIkjw6D2V2cLVL434+YGsBjElA/0ihK3DbZ4gBWofHjC4WAuufdkWFesQopamHg5dOqP/cJsKm6SJZVllpT/O+4hcO70T9szY3ZnX1siBGXbzUQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 07 Sep 2021 12:07:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

I consider it unhelpful that address and size of the buffer aren't put
in the log file; it makes diagnosing issues needlessly harder. The
majority of callers of swiotlb_init() also passes 1 for the "verbose"
parameter. 

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -253,7 +253,7 @@ retry:
                panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
        }
 
-       if (swiotlb_init_with_tbl(start, nslabs, false))
+       if (swiotlb_init_with_tbl(start, nslabs, true))
                panic("Cannot allocate SWIOTLB buffer");
        swiotlb_set_max_segment(PAGE_SIZE);
 }




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.