Re: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 7 Sep 2021, Jan Beulich wrote:
> I consider it unhelpful that address and size of the buffer aren't put
> in the log file; it makes diagnosing issues needlessly harder. The
> majority of callers of swiotlb_init() also passes 1 for the "verbose"
> parameter. 
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -253,7 +253,7 @@ retry:
>               panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
>       }
>  
> -     if (swiotlb_init_with_tbl(start, nslabs, false))
> +     if (swiotlb_init_with_tbl(start, nslabs, true))
>               panic("Cannot allocate SWIOTLB buffer");
>       swiotlb_set_max_segment(PAGE_SIZE);
>  }
>