[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown()

  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 8 Sep 2021 14:34:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PpEv5+mHfqiqUFwb1j4lcLdt4/wSHF+p1OudjtufR1Q=; b=m1NlxbkWqPAk+DLJHFALHwqVr8l/YwRYzXcNH7u9/k47rfnr8v5PD9Y/heHIg7JpczWwCw1iP92Rp/Q3gm33Lyr/kRjt9IMC4Oa2FB29t4MmEOwhKEPHTRQ6cyMPoZJNwFxbtGLRrl76U0ATvcQwGeIh4mkbT16SNjElxHfzuH3e2+qD1fwF1hhiS5GSx7b+ttMMGwwAYJB0uK7luu39pShPdhO402wH6WF+J/E+diucjfo+PeN6UUWnLmubOXx5ML71yJ/ZZ3m+xoA0OJi1tKX4ZjURC418S41KqFyHjdM4aIMKqWijDrjKHhr9P5EtExJ4dRe9P8Rh89w/nRgbqQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VqwT+9zpWiYbBPurU0aVLrTeIAyrCgCwv/H4MgaTrpwg8DxRh5fS1hBr/3o7A5PXG9Zik1+o0mf2bGORgAD/Km6D9q6ONPJeoH7UAWstkfhekrwhxGYR9VvmNteN0U536EbbafQ8o2TtcmaBU7kKFVoc7AG1bWM3P7i8QtB6FHMTfxPj6NlgIvZgLSFZHp3u95mG7wnaV+g73lCczo0LspYlnlQfwMAoZktQfOc/SK+kchGxRZjkFVGfPBOzI0M3+oMJD4fU1Ch8BmrnoEHO968AQ5T3nZayOaSRhGdIdkMUU7AqCR2+YJtMptyQhfacNfiR0a1++LinKIkur5C6VQ==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 08 Sep 2021 12:34:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.09.2021 12:32, Jan Beulich wrote:
> On 01.09.2021 10:45, Jan Beulich wrote:
>> Commit 806448806264 ("xen/domain: Fix label position in
>> domain_teardown()" has caused Coverity to report a _new_ supposedly
>> un-annotated fall-through in a switch(). I find this (once again)
>> puzzling; I'm having an increasingly hard time figuring what patterns
>> the tool is actually after. I would have expected that the tool would
>> either have spotted an issue also before this change, or not at all. Yet
>> if it had spotted one before, the statistics report should have included
>> an eliminated instance alongside the new one (because then the issue
>> would simply have moved by a few lines).
>> Hence the only thing I could guess is that the treatment of comments in
>> macro expansions might be subtly different. Therefore try whether
>> switching the comments to the still relatively new "fallthrough" pseudo
>> keyword actually helps.
>> Coverity-ID: 1490865
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> If this doesn't help, I'm afraid I'm lost as to what Coverity means us
>> to do to silence the reporting.
> According to the most recent report this did not help.

Just noticed that this was rubbish: I thought I had committed the change,
but I actually didn't. Now I'm about to - let's see what happens.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.