[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: remove stray preempt_disable() from PV AP startup code


  • To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
  • From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Date: Wed, 8 Sep 2021 10:21:20 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=r5DkWAm23nvRRUg/jAQr5y90goAn0GgNJDof9SZXWYw=; b=GBemeKD5g5a1txp/YX8m23XfbyV6UJkk9XrusQBLsZ0UUZAKSIHOoBTXn/t2c70tMRxIOq/V+pesCg+rdKsFyQOLUaVR5jdpt4sDLbVkg6p/k060qO/CNGeM+hO6cb4vdx67OcEWsrkB13qW4aVR0zsPVeyGJkjt/X7HB38KZzXoVrJ4bRJ/l0f5qsyZnPQt78nUwX8P8hWZ582We9LiW60WYrHhFUecyIQBhhWFXLaqDz6pzNRssIfu7PEMBV+ddZTLYdQBEFPzgsknSzEfi+5BreS6AlhMU+kDJr2fDKGX7n5m9KWUsztO3VCff/yeCm47uOTGeNakz38VxPIjSw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBj2ZtJP2tO/f1n9xwbmC/R2uqwvKW1U/xXLR8Es850XznSCfLrTOnys1N7ab2GtMJ87XVAdzOkDTy5svmkho7B7oI57jMfF0eKuEWqcCsRVkTsJ4u5x+7s41iKDdZUYGeZD3IHp2VrV8GBZhzjTwoEMn9MEk5lHYpzdR2pOUsEZmVI9OyesaIJihTUz+cEMVusJE4Uf0QBbWS0r5ir4WPWcBTkPB79mlnPtCxvGEZvnw8nXUqwZwDmt6pnMN7092Aggzd5g0mWaUP6ItyMuo/p02ACHRVmCXUaoOXC9O3HsXKeiYPmucgZ8SpYDnM3FqYI1t2n2H3tPiqdL1LepDQ==
  • Authentication-results: zytor.com; dkim=none (message not signed) header.d=none;zytor.com; dmarc=none action=none header.from=oracle.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
  • Delivery-date: Wed, 08 Sep 2021 14:21:50 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 8/25/21 7:31 AM, Juergen Gross wrote:
> In cpu_bringup() there is a call of preempt_disable() without a paired
> preempt_enable(). This is not needed as interrupts are off initially.
> Additionally this will result in early boot messages like:
>
> BUG: scheduling while atomic: swapper/1/0/0x00000002
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.