[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: fix usage of pmd/pud_poplulate in mremap for pv guests
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 8 Sep 2021 16:28:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=j6d9ZMxRtBBb6+QUt6hwEKx14KSM3R+s8pNB7AtZApw=; b=npA9YXS37OZ9eCnFZevG1Oe9sCiM53wc7KNME7aoBBxslib9tjgw8wUF1cUlCTJ3ku53+0dil6g3nvXPModqWf7WJE9QztQ+vFYHaFMEA9egf3nSCIrbm4EtvfrR4ZeiBJ++1TNerw7OosPCyFKcwYmsZVaoqGjsKAnlXjAVnoxM6mARgh5vpYa7t6K4wfBzJXnYkM+onOmACC31jERPaJn5z1vlnc8NmOFF51y9shoIhTZkQBFYZf/cx6Bf9GY5FervdZl/K1fnmXQ7jmTzSW6N/eXTDK99tz5h+f969GmERKBS4bHq6pwHXPUZgsjziL2eX0gcTzXUQ0WckOhsuw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K1f64Qoh67yKL/yyrd/J7B6Wv+f6AuZw1zvesc4pj+aVTmxpIrEgvPfoxOJeCCub6iUPXa5ha6VE7fAz3Qirgc0qs77HDEMnAsBdKZhzhZyyLFGLQh9U+4eCjUIROcWeZ2+wIFMBdMgm7vKW5levxk1cPcGCV7YeL3AQ8WUeOskXvGl10WqJTrnVVNVepsR5PgVlT9jkvhEixagRDKEddTX0gJBOSOYbS8jvUIxsU01GST+YAhZqLHlIyacfqIxBepw7276eMmRn+YK1R981tAiSrPUKZ1E9BmK3yLylWGFI3LSnF5/gUhHNrKcl2BYDAJphVBZpfH4iAtV7ZxGhOg==
- Authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=suse.com;
- Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Sander Eikelenboom <linux@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Wed, 08 Sep 2021 14:28:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.09.2021 15:32, Juergen Gross wrote:
> On 08.09.21 13:07, Jan Beulich wrote:
>> On 08.09.2021 09:36, Juergen Gross wrote:
>>> Commit 0881ace292b662 ("mm/mremap: use pmd/pud_poplulate to update page
>>> table entries") introduced a regression when running as Xen PV guest.
>>
>> The description of that change starts with "pmd/pud_populate is the
>> right interface to be used to set the respective page table entries."
>> If this is deemed true, I don't think pmd_populate() should call
>> paravirt_alloc_pte(): The latter function, as its name says, is
>> supposed to be called for newly allocated page tables only (aiui).
>
> In theory you are correct, but my experience with reality tells me that
> another set of macros for this case will not be appreciated.
Perhaps a new parameter to the macros / inlines identifying fresh
vs moved? Or perhaps the offending change wasn't really correct in
what its description said?
Jan
|
