[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 08/11] xsm: drop generic event channel labeling exclusion

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Thu, 9 Sep 2021 12:44:43 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631205891; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=fjPStVlaqAWOklvbdsZb4F02NclSWm/Ozl/EFyCNWKU=; b=Aru+lYZ8MO0rs2p9iQFc4vjtwU2RXuN9NAw93f4753OhLyDQJAZsDL76/zqwT+j6UyIWzQPflQ0XYb/drsxTCo6L2Bv6mg2TQMn+Y6W/mbNndV2imE+uigaZJyHz9x0Mgdq98WhWUtQCg4pEh8FUH7JAGTESs1731WKkPrMki5g=
  • Arc-seal: i=1; a=rsa-sha256; t=1631205891; cv=none; d=zohomail.com; s=zohoarc; b=SK4bv8DeioH6F7i7aFydxxpqV1FWfgs3Esu+32B3hrDQsKkjOiCmDbbKZifpdGgaJ3vJzsFNElKx4sRr8spE97PQjv6tepg1o3txzdoBs5VlXPv9bbtgkiUm6J09hu/Mhji8fwAhJ5y66RiQQDFaafKK+TpwziE9krIsEXJUVxw=
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 09 Sep 2021 16:45:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/9/21 11:35 AM, Jan Beulich wrote:
> On 03.09.2021 21:06, Daniel P. Smith wrote:
>> The internal define flag is not used by any XSM module, removing the #ifdef
>> leaving the generic event channel labeling as always present.
> Already on v2 I did ask
> "I'm not fully convinced of this removal: Does it get in the way of
>  anything?"
> I have no record of getting reply, so I'm still wondering.

I can't find any email record of it but I know I made this change
because of a request to drop XSM_NEED_GENERIC_EVTCHN_SSID since it is
completely unused. Honestly I am not concerned on whether this
completely unused field is kept or not that is behind a flag that is
never set but it clearly is concerning for you, so I will just drop this
for now.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.