[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 08/11] xsm: drop generic event channel labeling exclusion

  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 9 Sep 2021 17:35:25 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OaZlGOQVIu/SHCco4zvHNMIsRoe3fyRLX5UBV2NO/tU=; b=gYL3fQ2Th0HY6aq1e1p4le45VFsKUd4QNZKHqLDX92kUpzXbZB1eTHDyWp22sMLiG071UcuEeUF3r8VDbd1+kdqpYZgGI0c6wP5ygAqEMhzEZcYOzlgLzGXA8+Nhi2zgvBIUrIpM1OUxX8BrxF8MfqgRpfrUiMd0+zijoE13G2xXi/xV3TBpaj/Xuj7LPyrS4PwLPyq775y9v8qgrQLAF1ppWxWMNrisMA2CthAwkytfd6wZGri6kOG/cyXS9V4araRveyMKnYlDtTVBBVHlwDhBTUryK5fyNcFklS/7tlwzu7dDt1sdqZm6JSTvyD/2WprbSYg6+1a/UWFdijBGUA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDFT9ujSQSI5/b/T2MG8G1lxxDyzeZ2U15vSH3q30Cf4sjpudrWxv0OPHO4B13zg/kwb/4Yt7CVk/ep7JHPCdEpYzAH6hCwVA7UbboY2fSJKLMDIZGoBtvos1suKFNZqh4zIwa2/DWPIn4mRxdY+iQKPZaxj7XZGeXyPd4hyb9gtMsJafv2TEtsetcaCWX7G7OAOupsckdCpnVfSIzo7sNp0BFxoauRoSXIzAv88ftXnWqwz1bVkrA9BBSCM8kXxppjbtmYshFBwfTFN7XgsMFGyLkMpM4U48anW3+p5pmTTeSC4cFyCGn3Cj/AgtC7k/V7Zx2lc+ZJjHoBrtto7cQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 09 Sep 2021 15:35:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.09.2021 21:06, Daniel P. Smith wrote:
> The internal define flag is not used by any XSM module, removing the #ifdef
> leaving the generic event channel labeling as always present.

Already on v2 I did ask

"I'm not fully convinced of this removal: Does it get in the way of

I have no record of getting reply, so I'm still wondering.

> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -122,13 +122,11 @@ struct evtchn
>  #ifdef CONFIG_XSM
>      union {
>          /*
>           * If an XSM module needs more space for its event channel context,
>           * this pointer stores the necessary data for the security server.
>           */
>          void *generic;
> -#endif

I don't consider this any better than what you had originally: Then
you've removed everything inside the #ifdef as well. Now you keep
it and drop just the #ifdef, exposing the field universally (as long
as XSM is set) despite Flask's 32-bit only field being enough for
all practical purposes.

What is there demonstrates what the original intentions were. It's
easy enough to put back if needed in the future, but I think it's
even easier to simply leave as is.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.