[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/10] xen: Implement xen/alternative-call.h for use in common code
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Sep 2021 08:10:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m9uOvY/Pl51wD3i0eQQ8FBhnALb8LVICAwNjRHuvdLI=; b=TovbCvxvVF9JDCBFIild87SDMxpEmdepkF5bKmGRIYQs3X1JV8O1ofwGzAUVr/K83m2EjIxbSu3blmUe+YoPbLKIvmV9MAMcUjBjMsqWk0UIKaVoX+HEm1JwCjPRj/aPrXBVEZjjQSbez+ZNii9vT8zDSmz4Ic3ami/rSzcLFzsc6AahnpG8UfC8Wh4CMSu4SUekdN8rjtrG2vEFmQMKSwFWXytPtN+xXIDvgKlWplP8PuuBZs74jRi1k/G6LKLSPZSBeExoVqB7LAfRIR7xYqbk0HFy/c2uYFCW7Pr+RtoMXPvKfAjuYg5O35Rm7jmAOYWS+LGCuFDT43UnjOqB2Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kz4J99pX0C3HzDzKrGUH1osSo3NPvylBDpnmc7Edfpa212vfQX4o/YSaYIsuMecibdnELtjuAwkpT3/AdKFtvhTXSTdojUWsyS8JVPjwi16hUUHrcLh+v2QtTwd5IWaAmVfKzh9nBWhUA4BrScHI6nUH4p3JpDYtgWakNui+F12m5841GM/WkObg14UUDL/O9l0XWvujSqZjwCY4lrpaUMDd9PkDNMjlB/xgyYjpB1wecwvXAMg7XqU8TAsoozE8zhcPtT64yBkWRCNyvzvFoqAMfc5HEvCeFgNHMDq8uutZBAOdioXhY5hdTMYKHjdVrrg6XTdmjpcDEyRfGq+f+Q==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 10 Sep 2021 06:10:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.09.2021 04:12, Daniel P. Smith wrote:
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> The alternative call infrastructure is x86-only for now, but the common iommu
> code has a variant and more common code wants to use the infrastructure.
>
> Introduce CONFIG_ALTERNATIVE_CALL and a conditional implemetnation so common
> code can use the optimisation when available, without requiring all
> architectures to implement no-op stubs.
>
> Write some documentation, which was thus far entirely absent, covering the
> requirements for an architecture to implement this optimsiation, and how to
> use the infrastructure in general code.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
I did offer an A-b on v4, dependent upon two small adjustments. Was it
deliberate to neither make these adjustments nor add the ack? (At that
point I did offer making the adjustments while committing, but I think
it goes without saying that upon re-submission the changes should be
made. Unless of course there's disagreement about making them in the
first place. Yet such disagreement would be worth making explicit then,
imo.)
Jan
|
