Re: [PATCH v5 01/10] xen: Implement xen/alternative-call.h for use in common code

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 9/10/21 2:10 AM, Jan Beulich wrote:
> On 10.09.2021 04:12, Daniel P. Smith wrote:
> > From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >
> > The alternative call infrastructure is x86-only for now, but the common iommu
> > code has a variant and more common code wants to use the infrastructure.
> >
> > Introduce CONFIG_ALTERNATIVE_CALL and a conditional implemetnation so common
> > code can use the optimisation when available, without requiring all
> > architectures to implement no-op stubs.
> >
> > Write some documentation, which was thus far entirely absent, covering the
> > requirements for an architecture to implement this optimsiation, and how to
> > use the infrastructure in general code.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> I did offer an A-b on v4, dependent upon two small adjustments. Was it
> deliberate to neither make these adjustments nor add the ack? (At that
> point I did offer making the adjustments while committing, but I think
> it goes without saying that upon re-submission the changes should be
> made. Unless of course there's disagreement about making them in the
> first place. Yet such disagreement would be worth making explicit then,
> imo.)
>
> Jan
Yes you did, perhaps I did not follow the thread correctly. Re-reading 
it you mentioned they could be addressed during committing. Since I am 
going to have to respin this because the hard-tab foul up, I can pick up 
those to adjustments and add your Ack-by.
v/r,
dps