[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 05/10] xsm: apply coding style

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Fri, 10 Sep 2021 06:04:39 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631268387; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=QEjZX0zuy3A6qMLNdFILZu10UrGIeNde2vBbeM+kN9o=; b=QApNXB/zxGbP30KURDmIMh0dnCnqYG3EJVv87Ka8utwZ02vfTqgSkh5+BIpRfQIEC03eud4W/WAd99DrUcjkwUzeUgYaqrxGYcT78yki9JRBbgWLAqX+mcSxkTcmx0zZvaziZpwHzH+JYCNe1SbsAOY3kUSFy35mzPf6ugp73KA=
  • Arc-seal: i=1; a=rsa-sha256; t=1631268387; cv=none; d=zohomail.com; s=zohoarc; b=BGmHo5Akbbsj/xfbtRFimf0JZCjDHbYhYHKHPW0NOKtl/fzRdxmefXas4bV1XI8GCuh+jE8Jx7pQwRqAe8qIOjc2QpCYFGXRP9//5attJzHVt3eP2SbBC8SQzo45u+u7QcoHHaOwkM1wm5bu2OmWTui7lIe6i0AoNnLHrttjDRI=
  • Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 10 Sep 2021 10:06:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/10/21 2:15 AM, Jan Beulich wrote:
On 10.09.2021 04:12, Daniel P. Smith wrote:
@@ -70,7 +73,7 @@ void __xsm_action_mismatch_detected(void);
  #endif /* CONFIG_XSM */
static always_inline int xsm_default_action(
-    xsm_default_t action, struct domain *src, struct domain *target)
+       xsm_default_t action, struct domain *src, struct domain *target)

Here and below you're now introducing hard tabs. In Xen style
we don't ever use hard tabs for indentation; this is limited to
files inherited from elsewhere.

It's also not clear why you've touched this instance at all:
The 4 chars indentation was correct already, as previously
pointed out by Andrew (on perhaps a different example).


I honestly don't know what is going on. Since right now my primary focus is on Xen, I have my vimrc set to 4 space tabs with expand tabs and I am not manually changing. I will retab the file in the next submission.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.