[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 05/10] xsm: apply coding style

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Fri, 10 Sep 2021 06:41:33 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631270601; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/4QfoESrYxGzqyr1l71wmYw4NxxbWHrPuKAOvJt+O38=; b=Gvk9wCtgbIo6SNt1L23V0qG7u3AXfXyAXDSbL3AjM9amYOobrzEG4TxjrksQI2ph4+wdot5WMjMseO/E3Aebm48eptVYI06UtUQGRyw0QA8qf9UihkutO1tReFmRQiNN3vBt0Q8ZFszLCuIaVO3PafK8u9UNepFImgKTdh/5jvE=
  • Arc-seal: i=1; a=rsa-sha256; t=1631270601; cv=none; d=zohomail.com; s=zohoarc; b=gW9dAaSibMbt9EnnYMXY6pFS0ij/1RlWloEiNteT1C1LQ20ei36c/nCuN1U8xEXR/oRUZrFP0PAgCjBDtrox4PcPBwHIuvanM6QbPJw2oIfSnLG9U0EW90phKyeJZ8Q80BHahsCq2RjxtgafEflgCW78EBLCSyG+UNbblOo88PA=
  • Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 10 Sep 2021 10:43:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/10/21 6:04 AM, Daniel P. Smith wrote:
On 9/10/21 2:15 AM, Jan Beulich wrote:
On 10.09.2021 04:12, Daniel P. Smith wrote:
@@ -70,7 +73,7 @@ void __xsm_action_mismatch_detected(void);
  #endif /* CONFIG_XSM */
  static always_inline int xsm_default_action(
-    xsm_default_t action, struct domain *src, struct domain *target)
+    xsm_default_t action, struct domain *src, struct domain *target)

Here and below you're now introducing hard tabs. In Xen style
we don't ever use hard tabs for indentation; this is limited to
files inherited from elsewhere.

It's also not clear why you've touched this instance at all:
The 4 chars indentation was correct already, as previously
pointed out by Andrew (on perhaps a different example).


I honestly don't know what is going on. Since right now my primary focus is on Xen, I have my vimrc set to 4 space tabs with expand tabs and I am not manually changing. I will retab the file in the next submission.

URG, going back to correct it and I now know how it happened. My regex substitution to assist in the mass reformating injected a tab that I expected expandtab to have expanded for me. I should have known better and double checked. My sincere apologies for causing unnecessary noise.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.