[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools/libxl: Correctly align the ACPI tables
- To: Kevin Stefanov <kevin.stefanov@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Sep 2021 11:30:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2mzhn0mvrPIwJZv0btGOpnNToczTHAHpNNtCJ5kQjZk=; b=Ol0YpJf/1hOG2JSDOIyqDx6F4rWw6SKQ33NP3+tnPvqF2K+wkVq+QwGGUVccUnBrbTBJ/w5PMMKDO+0qkHR1yD72HfBd3D6Y901fkVsJMmzx/vVWk9hR//KW0a/VvlD3dVd0EVj74o+TXTTAeyEGVBmZIfceyada0COYliJ76y46DfjHN9oaHxLLMcWmSTCBIrk3xGWVIw+tbTk7GQVT0UFTpm7/bQZTKboy4bTJVz5vkAxHdq7cTSQT7Kk/LVbT/QEOCWu3vwrx6UaU2umP3EktsqsRFK7awzeJrZp1llKkF/WY4vBF3o4dzVnEICA08TwBKjMn2NaOSZnPNo8LOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpzmGlMzE/tm+YiQjUNksTO4HTTEowf5CViqdMkeYrC0Btp0Z8PmkwjEknVXmZRVKR94KUeFqgVGOOQ2EVBE6kzSA2tgt9OQzdXZ7onX9tZ2iXtbkdh1pSmEV0ZCmpYN9ag6gSKo5NKuG0739MPWUKMbkoX3hIJa3Mvq0Fo2Iw9BqD/dxEoxwpSBp0/d+lEt3DWFw8PlVnkQhx+9ZsCmGWGi/J5DaI78JfDUc1Rpx1+F0uKxWyDN4bD1muxvwNHBPFvAHxu8CPo7QIQ7M/IXf/zmVKUyPlSyuFRnb+IA28lD3tpZymwF9Nx01fZdabxpK5KzwNSnuusW6/wH7AJsGA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 Sep 2021 09:31:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.09.2021 18:43, Kevin Stefanov wrote:
> --- a/tools/libs/light/libxl_x86_acpi.c
> +++ b/tools/libs/light/libxl_x86_acpi.c
> @@ -20,6 +20,7 @@
>
> /* Number of pages holding ACPI tables */
> #define NUM_ACPI_PAGES 16
> +#define ALIGN(p, a) (((p) + ((a) - 1)) & ~((a) - 1))
Wouldn't this better live in xen-tools/libs.h?
> @@ -163,7 +159,6 @@ int libxl__dom_load_acpi(libxl__gc *gc,
> struct acpi_config config = {0};
> struct libxl_acpi_ctxt libxl_ctxt;
> int rc = 0, acpi_pages_num;
> - void *acpi_pages;
> unsigned long page_mask;
With, as pointed out by Andrew, this now dead variable also removed
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
