[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools/libxl: Correctly align the ACPI tables


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Kevin Stefanov <kevin.stefanov@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 15 Sep 2021 12:05:08 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/8NYyk/vjXp+GbEJC9szBDZ+NqHZduKItzBrrbkmeJo=; b=GQgfk3EPRVwDfgbEVAdT9QCoBzk1tSs2pyDUZF38r36CN/J7k7pRFkZQqI1qqhruOgVO7kmjjTP6dZ/LivJMO0uIrwZ1Ahp5/SoF50H9wRVT5T+mYLa+7pfpz9gHzPcjAJR3qKR7WAYdK52HC+MD1kJ0poToLP3CsInEa41wR3lt4+x5BU81QUtTjC4hzHh3s3l5gX2TLE3r148JH7X8oH+sMuqNfzIAUdZtpQewFpc/5VkfN8L/0UeNydtc/2zpN+secfAl1E0OdMdxwnp9z2FPk3LxbojTOwkTpzDLPSAgC1Kd8/JWcmrb6Ht5kXEHkdVkLYO+sSb/Grao1+wH7A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWMVBjbAbJZS3ZN+bq/y5Ae9tRp9TUMySIsBeDe8GCPKPToz505yNU7zmMlUXYhGGwLTIjrifND/YmlaF/szM1O5SL3qdKVmSCpW7gMH1V4NfzIGwzE4fYV5D2BoOeDGFlXbcTibZx6Epcr6/piOSK91SzJVEH8345nWTAnE7iT9xzufZz5pnCUbgBcS5/9h1onOSotYKBK+Q9tx5cBKW6hZQDMijicw1Pu2qe1r/1QnGRaYa2Kqdmdbzqg12eX/s12Gp7WbZYgueOZ8anhhK6t/TW8HxOtGMGLOhyQDTbCQUbPkIfC50/00A28hiBLhWrHqOYryY2BYSTrrg7xs/Q==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 15 Sep 2021 11:05:22 +0000
  • Ironport-data: A9a23:YnX5561TGKDvjAMT/vbD5QJ2kn2cJEfYwER7XKvMYLTBsI5bpzxTy jBLXzuFO6veMGejedFwOouz8RhS7MfTn9I2SwNppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970EoywrNh2eaEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhueh01 P9vsbiJZywEZYnsh9YGdUl4HHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t2p0SRaqFP aL1bxJ3TxH8cjBMO20vGc0Fpe6nuHr8XQRh/Qf9Sa0fvDGIkV0ZPKLWGNvKePSaSMNNhEGaq 2nauWPjDXkyNtaS1D6E+XKEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb UsO9UIGsqwa5EGtCN7nUHWFTGWs50BGHYAKSqtjtV/LmvG8Dxul6nYsaAZEdPYEsOsPaxcHj XupgOHyI2xPv+jAIZ6CzYt4vQ9eKABMczRbOH5bElVcizXwiNps1UOUF76PBIbw14esSG+qm 1hmuQBj3+17sCId60msEbkraRqXr57VR0Ye4gzNVwpJBSsoOdb4O+REBbXdhMuszbp1rHHa5 xDoeODEtYji6K1hcgTXHo3h+5nzu5643MX02wIHInXY323FF4SfkWVsDNdWfhYB3iEsImSBX aMukVkJuM870IWCNPcqC25ONyja5fe5Tom0PhwlRvFPfoJwZGe6ENJGPBXLt10BZHMEyPllU b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgvuqWXTkk3PPUy2PyXOF9/o8TKmM4gE0U9ziF6Jq o0Oa5TTkEw3vS+XSnC/zLP/5GsidBATLZv3t9ZWZqiEJA9nE3smEPjf3fUqfIkNokifvrugE qiVVhAKxVzhq2fALAnWOHlvZKm2BcR0rG4hPDxqNlGtgiBxbYGq5aYZVp02Ybh4q7Azka8qF 6EIK5eaH/BCajXb4DBBP5Pzm5NvKUawjgWUMiv7PDVmJ8x8RxbE88PPdxf08HVcFTK+sMYz+ uXy1g7STZcZaR5lCcLaNKCmw1+r5CBPk+NuRUrYZNJUfRy0ooRtLiXwiN4xIt0NdkqflmfLi V7ODE5B9+fXooIz/N3Yvoy+rt+kQ7lkA05XP2jH9rLqZyPUyXWunN1bW+GScDGDCG6toPe+Z f9Yxu3XOeEcmAoYqJJ1FrtmwP5s59broLMGnA1oEG+SMgauA7JkZHKHwdNOputGwboA4Vm6X UeG+997P7SVOZy6TA5NdVR9NunTh+sJnjTy7OguJBSo7SB6y7OLTEFOMkTekydaNrZ0bNsoz OpJVBT6MOBjZs7G6uq7sx0=
  • Ironport-hdrordr: A9a23:aM3cfKytOG+1TWofyA9kKrPxMegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBTpTlEAtj3fZquz+8B3WBxB8bhYOCCggeVxe5ZnPXf6hHbMxTk8ORQz7 1tfsFFeYbN5DRB/L3HCUyDYqUdKbq8geWVbIXlvgZQpGhRAskOgXYbe2TrazwPeORfP/oE/d inl7p6TlKbCDMqh6+AdwQ4tp341qL2feXdEGI77nAcmXOzZAeTmfjHOind8gYVVjtOxbs40G 7ejgD13KWstPmn1gTRzSv2445NkNXs88BEDsCXkMQZQw+c7zqAVcBMSreGtDAwrPqO7E8wkN 7Qix08P8J1gkmhGF2dkF/AygPk2DYr52TDzUaCgXz/hMTlSDUxG6N69OVkWyqcx1srudl91K 5R5nmepopzBQ7Nmy7sjuK4My2C23DE/UbLXoYo/jxieLpbTIUUgZ0U/UtTHptFNCXm6Lo/GO 0rN83Y7OY+SyLUU5iM1FMP/PWcGlAIWjuWSEkLvcKYlxJMmmpi8kcezMsD2l8d6ZMUUfB/lr H5G5UtsIsLYt4dbKp7CutEa9CwEHbxTRXFN3/XCUj7FZsAJ2nGp/fMkecIDdmRCcg1JaYJ6c T8uRJjxD8PknvVeJOzNUhwg0PwqGbUZ0Wg9igR3ek8y+rBrHyCC1zbdLlkqbrVnxwlOLySZx 5oUKgmW8MLZVGebrqh/zeOAaW6ekNuDfH8TL4AKhOzSvyiEPyhigQtGMyjaoYFVwxUBV8XJ0 FzHwQbFf8wo3xDAEWIySQ5c0mdMXDCwQ==
  • Ironport-sdr: bPfa+JX68P+FQ2i+8rREjHkiLeAGj/D0W/9qsgX/O4jKf8u8jZ9boBcJT53wnlyPeI6h8TUQ9Q FAedE4oj1iyR6vIbLZ6Bteqijxq25QBVKpHP4LnYVYzBfqqIr6GFJZZV2Tgvo8JWkwgisWuU0X 0OsDjrFgvZpWi6lJwK20vKNsIQlho4ToytJWzin7nKt9JhyHEpv0WA8NMKjQqzwhBw4HQMG6it PaP8IHmgrppdTz5ts2Xxr/8f1L4+BAAQGR2DM65RuYg73d9P/Ih1oOvXdFs6dxMs2dOvRr8cDP QqsGrZTSqiWgwMnJru8IsWXf
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15/09/2021 10:30, Jan Beulich wrote:
> On 14.09.2021 18:43, Kevin Stefanov wrote:
>> --- a/tools/libs/light/libxl_x86_acpi.c
>> +++ b/tools/libs/light/libxl_x86_acpi.c
>> @@ -20,6 +20,7 @@
>>  
>>   /* Number of pages holding ACPI tables */
>>  #define NUM_ACPI_PAGES 16
>> +#define ALIGN(p, a) (((p) + ((a) - 1)) & ~((a) - 1))
> Wouldn't this better live in xen-tools/libs.h?

In this case, not really.  That file doesn't exist on all versions this
bugfix needs backporting to, and there is an unknown chance of collision
in older trees.

This would be a whole lot easier if ROUNDUP() wasn't in a dubious state...

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.