[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V2 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo

On 16.09.21 18:47, Jan Beulich wrote:

Hi Jan

On 16.09.2021 17:43, Oleksandr wrote:
On 16.09.21 17:49, Jan Beulich wrote:
On 10.09.2021 20:18, Oleksandr Tyshchenko wrote:
@@ -120,6 +120,7 @@ struct xen_sysctl_physinfo {
       uint64_aligned_t outstanding_pages;
       uint64_aligned_t max_mfn; /* Largest possible MFN on this host */
       uint32_t hw_cap[8];
+    uint32_t gpaddr_bits;
Please make trailing padding explicit. I wonder whether this needs
to be a 32-bit field: I expect we would need a full new ABI by the
time we might reach 256 address bits. Otoh e.g. threads_per_core is
pretty certainly oversized as well ...
I take it, this is a suggestion to make the field uint8_t and add
uint8_t pad[7] after?
I view this as a viable option at least.

I got it, sounds reasonable.



Oleksandr Tyshchenko



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.