[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] domctl: hold domctl lock while domain is destroyed


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Dmitry Isaikin <isaikin-dmitry@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 16 Sep 2021 18:52:20 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3GDBpvebfB/L2nkRQc5xS7kV2QZ9dw0uo8UFwVeRI6M=; b=ZWohzHZng1EwXnLd8UzV220F23b32X4KwDzy6qb4YhY0/S9iNSXkDFD7NuNVnHJS2Psypv1oakqmDu1SBt1zG+1+owzsg8Sbvh928d4yO02EkxnDb3M2fxhnSENHeEqSK6AMA+ToVWrQSww6d9KcNK2hK2vavV51XkiDpQsJQjM8nSYWb+4BCXXZRLxwGIO9C/rh8C2hvAr3PVLz4Bo8KK/D/9UnKAj4imDoT9He4x0HN8/JQ/r4IWqWsLog6ba2Q6kgDa8ciK5tVpnNB2Nx0ssF5NbftFbOzPxu8PTBG5oTvcgirDxIUvIhIhOljr9pJdfYHDINEOXdI3fMOhwhdQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P86p+9ImKYpdANxLTf+4uQ6lt7UqK1bDiEqPoelIllJo+JjOM864aqe9VRMhBwyPulPEoJKRQWGT9eFNG00ScNCW9MtgFNaDhLyl1TecIiybXakxvKNEu8Z7aBW69T15U/k19fWawyGazY4si6TQwUuxObmUWah2CoBj1PGWAON9vbBKC5X1ZP8+iIxhygBI1hdb7SLT4Tn4MufePxOm08wCaoRySBiE+W+VEWVgc630Kw45tx9/GmE/egptI+XEK0VZItnnDlqs1GJSe0MunuGTLHoqN5ei2cM6Hxk66nuJVoiEWAbGieyvXe3MHWp64+k0dbrLnxhUHPfozSxSxA==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 16 Sep 2021 17:53:13 +0000
  • Ironport-data: A9a23:kl9Os6sATwBqdn7FMcr4pR/05OfnVMVZMUV32f8akzHdYApBsoF/q tZmKTyOMqyCa2GgKookOYW/phxUuJPXn9FqGVRo/Cg8FXkW+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHpJZS5LwbZj29Y52IbhWGthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplpYOCSCgsOLXwv6dGSh9ZKwxdGot55+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6DP JFDOGQ0NnwsZTVvM3wWJpwChd6axXXGTxl7sw6JuaMotj27IAtZj+G2bYu9lsaxbcRKnG6Iq 2Te5WP7DxoGctuFxlKt82mlh+zOm2b3XYMODqyQ5/dsjFCDgHYOYDUUX1ampfiyimalRslSb UcT/0IGr7U29UGtZsnwWVu/unHslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9W9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHeTJob10yVCIw5Sejs04OzSWqYL y22QDYWl6ohjOEO0b2H2hOcmjStnrXqaSgK+VCCNo661T+VdLJJdqTxtwOCsKcfc9jAJrWSl CNbwJnFtYjiGbnIzXbUEbtXRNlF8t7YaGW0vLJ5I3U2G91BEVaYdIZM6XlVIE5zO67okhe4P ReO5Wu9CHJVVUZGjJObgarqUKzGLoC6TLwJs8w4iPIVOvCdkyfdp0lTiba4hTyFraTVufhX1 W2nnSOQ4ZAyUvwPIN2eHLx17FPW7npmmTO7qW7Tlkz6uVZhWJJlYehcawbfBgzIxIiFvB/U4 75i2ziikk4EONASlhL/qNZJRXhTdCBTLcmv96R/K77SSiI7STpJI6KAntscl3lNwv09ehHgp SrmBCe1CTPX2BX6FOl9Qis/Mei+Ackm9itT0O5FFQ/A5kXPqL2Htc83X5A2YaMm5Kpky/t1R OMCYMKOHrJETTGvxtjXRcaVQFVKeEv5iASQETCiZTRjLZdsSxaQoo3vfxf19TlIBS2y7JNsr 7ql3wLdYJwCWwU9U5qGNKPxlwu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1 xybCAszrPXWp9Nn68HAgK2J9t/7E+Z3EkdAMXPc6LK6aXvT8ma5mNcSW+eUZzHNEmjz/fz6N +lSyvj9NtwBnUpL7NUgQ+o6k/pm6oK29bFAzwliEHHaVHiRC+ttciucwM1ClqxR3bsF6wG4b V2Cp4tBMrKTNcK7TFNIfFg5bv6O3O0/kyXJ6ahnO13z4SJ68ebVUUhWOBXQ2iVRIKEsbdEgy OYl/sUX9xa+mlwhNdPf1nJY8GGFL3ohVaQ7t85FXN+321RzklwSM4bBDiLW4Y2Ub4QeO0YnF TaYma7eiukO3UHFaXcySSDA0Oc1aU7iY/yWIIvu/2i0p+c=
  • Ironport-hdrordr: A9a23:SiqXiKOhQoo59cBcT1b155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/OxoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyYygcZ79 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY9ts2jU0dKT2CA5sQnjuRYTzrdHGeKjM2Z6bRWK Dsnfau8FGbCAoqh4mAdzU4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4kLEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z bxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72zeBsKT+56wa5JeBrQ7EQt+Ptm1r hQ4m6fv51LSTvdgSXU/bHzJlJXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP JlAKjnlbZrmGuhHjXkV1RUsZiRtixZJGbAfqFCgL3V79FupgE686NCr/Zv2Evp9/oGOtF5Dq r/Q/1VfBwndL5gUUtHPpZ1fSKAMB2Fffv9ChPhHb3ZLtByB5vske+83Fxn3pDmRHQ3pKFC7q gpFmko7VIPRw==
  • Ironport-sdr: iK7ikIm5m0LJIiMKKLwYYTD+K3Yhx9qmM3h9PfHqkFq3ZYgjKtx8K1mCv7PTzMiHbKQ0fulxCs IdX2aHiqbF+REYZoem5FZ2VBkj2CLdwfbjLY/F13tIFmY8hfGvK0TPr1iLHhOCwY8vBxzpeodt kZjkxySgiwhC2CA/pi2jGw8eYaEn50sInR0Bh57UW/yCiEKVPU0Gr9zcJuXOKFSbreuqu0PWjv 16jhgyzoCHd6euZJdm1SL4pU4dHEhXm+ZsdZtxzFOjXoZ64CEIz111NyJbkmZObNulm8Gpn8fd ab9noJtJz9LBqdzwlu3EbWmF
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16/09/2021 13:30, Jan Beulich wrote:
> On 16.09.2021 13:10, Dmitry Isaikin wrote:
>> From: Dmitry Isaykin <isaikin-dmitry@xxxxxxxxx>
>>
>> This significantly speeds up concurrent destruction of multiple domains on 
>> x86.
> This effectively is a simplistic revert of 228ab9992ffb ("domctl:
> improve locking during domain destruction"). There it was found to
> actually improve things;

Was it?  I recall that it was simply an expectation that performance
would be better...

Amazon previously identified 228ab9992ffb as a massive perf hit, too.

Clearly some of the reasoning behind 228ab9992ffb was flawed and/or
incomplete, and it appears as if it wasn't necessarily a wise move in
hindsight.

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.