[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] domctl: hold domctl lock while domain is destroyed
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 17 Sep 2021 08:17:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rh/EC3CAU/E8XbmlJ9mJqxNlOX4p+TIrptso6vc3xdI=; b=WD93xzn2iL6TbrNzz6YWS4x9VcAoDu5tA2hmfh4JWzUohCQAmAU5GxdsVk0+VPoLKHaJwFZsWfeYiGRBX36I2B/xWFlnrfn6eBbqJJzo/OEvITiSs/7585jbYFcSMmei/nqdg7Z75QoBcKO6H0O41Hupaw3rwySEqEXKoscyT1CON7MG7mo+6qU/eIrqtvP3njos+Snckmsv0xWmimXAEVZFVQ8HNZ58GBasVDRQHITsXd9FXtD0xaSPYaJTL6hOU8l/yI1OuaTdCdOlli6yWclHHRm/t/bzHsh/cEIcwgCRM3APgrW2TiIJY2M36RDA/vvMznBXsna6I8EuglshZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZsjoerqQX7xjsY7AZmXcZwLnkHcunE9VKx9J4DZzwwagW/4WJ/E5rq/7U/Znj9g8+Sqw2PdImwTNDQ4su9YxUQ/zh6x4wBnYgjUy9VoSxk9RmJ3usR20GocOzr18UmYovqxogaWc8etRGS2uZhtTIg8ND948pNEqHIHgqdseHhxdHoo6LYY5A3xJs0ll4Un4kQaRylypkOmGP8n1nBuJwm1LwDQ+33OsjD4ceDz9TtL4hdxrnqVE/f9oS77DTDiEnEa9BGmOQXdQHGY3EsToLrz0yfalKV0Dv70HsPj2CpGT7cmbS7SI8kz6peosOv6EFf/2QXAtDACli/9Jn1Ptkw==
- Authentication-results: yandex.ru; dkim=none (message not signed) header.d=none;yandex.ru; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Dmitry Isaikin <isaikin-dmitry@xxxxxxxxx>
- Delivery-date: Fri, 17 Sep 2021 06:17:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.09.2021 19:52, Andrew Cooper wrote:
> On 16/09/2021 13:30, Jan Beulich wrote:
>> On 16.09.2021 13:10, Dmitry Isaikin wrote:
>>> From: Dmitry Isaykin <isaikin-dmitry@xxxxxxxxx>
>>>
>>> This significantly speeds up concurrent destruction of multiple domains on
>>> x86.
>> This effectively is a simplistic revert of 228ab9992ffb ("domctl:
>> improve locking during domain destruction"). There it was found to
>> actually improve things;
>
> Was it? I recall that it was simply an expectation that performance
> would be better...
My recollection is that it was, for one of our customers.
> Amazon previously identified 228ab9992ffb as a massive perf hit, too.
Interesting. I don't recall any mail to that effect.
> Clearly some of the reasoning behind 228ab9992ffb was flawed and/or
> incomplete, and it appears as if it wasn't necessarily a wise move in
> hindsight.
Possible; I continue to think though that the present observation wants
properly understanding instead of more or less blindly undoing that
change.
Jan
|
