[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping²: [PATCH] x86: drop a bogus SHARED_M2P() check from Dom0 building code
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Sep 2021 08:10:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=T1NeMOJA8ig+J/2JyYIqUyNFp0jZMGc3hhutzA+lpWg=; b=NZJZp7ofPyzDvjGXSOF73G5/uWwYneOJetojwuPkxrV6NBEimuhLjdMiNyFINJKobAtmJVd2O8l+aXheUXm+V++ikF74IORiAssQs1rSUjc+KY7LvdJ0mSum4/V0p9hIpBczOai1pJNiDPoe5WghaL5I3IG7JmDFH1D/2ZXMDodwhOjhuB/1sA0RDl8fdkwBF28BwGZdG4+DepHBX7an9teMs+vn/zVt1PdZO2B9kYL1gKKfOM9qy7WS0/4x9lHGq233HoBcQKmC9qHN+mO+wNBcDbyhGHWS504+BLTHCj/fSnxMMOqcZFor5pLOC3Y0jcRgl8xfFNV/sweIKmgl5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+DnEv43qWQYRBZiQGYPWqpS1cZw72xYHeLNfG3kPK6tcTk1fmITnoujO424aIZ6JCbFKYuEBoDY/vs8E3NDQguo3nCY9+buAbDtML+K3ewSpHegOV4i5VDBLBkwh0N2Lx7jEAOj6W6DaPpTvRciPjM+XfMcDT2Rq57dWLMyLqp0dMiexyCnGl+KRLOi2ZdC2pXw25U2JODuuUf804q36/xgCP6RTdyMl8LodCUWi/W5T9J5UWzkh8OcGEX9Zn3csMADRndCCfpO9WpN4lZtrsPyLam+sKQNGhangBIKqwqrY5vuUtDcffHwrBhgl+MyXlmj7bJBlaabnfv5CJR5iQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 21 Sep 2021 06:10:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2021 09:37, Jan Beulich wrote:
> On 28.06.2021 13:52, Jan Beulich wrote:
>> If anything, a check covering a wider range of invalid M2P entries ought
>> to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
>> control at this stage, simply remove the BUG_ON().
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> I didn't expect this to be controversial, so may I please ask for an ack
> (or otherwise)?
To be quite honest, I find it very strange that even simple changes like
this one sit un-responded to for months. This isn't the only example ...
Thanks, Jan
>> --- a/xen/arch/x86/pv/dom0_build.c
>> +++ b/xen/arch/x86/pv/dom0_build.c
>> @@ -815,7 +815,6 @@ int __init dom0_construct_pv(struct doma
>> page_list_for_each ( page, &d->page_list )
>> {
>> mfn = mfn_x(page_to_mfn(page));
>> - BUG_ON(SHARED_M2P(get_gpfn_from_mfn(mfn)));
>> if ( get_gpfn_from_mfn(mfn) >= count )
>> {
>> BUG_ON(compat);
>>
>
|
