[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ping²: [PATCH] x86: drop a bogus SHARED_M2P() check from Dom0 building code


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 21 Sep 2021 09:55:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MBnF5FzmPnb0gAxehp+w3uDQohymLw4+XjrSrGtkyec=; b=Fxd8aWCrd7skIQkA0oseYMlOXrX8ordUliQXxop48+MvB7+ZD7x1kmbH41j42chKL5JVDcylDCNl4aDMF4+2wgS3xXmNikji+1QZTDcEYDdlbGTeDhhQsqXkfcG6gLFtIFZOGdaRxZre97QizbHZ6GANwv3py0smF+u2ErmiLcLojG5NaEFxXJgHYteQ2HmKKJ7LaPdgATCnj/PCJ7ApeGpWr6aZLzUgmrhJPFOOmyR0CGR38QQLfImrOXFQSQZJxGqJXnZH8bNbtA9yrADiE+I0iGkcRjIeg035TTBuLDnCg7kvcFCeljcNaGTxfGOT/DX96FuUKsg9Q8KRfhlorw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBJFW/QMPLxcAscVnu1vAXb3++1QPhA9uJu5MOrlNDKmgByXur0IfAy3LQHLixk0/zyGyqoYd4DErXcdjAhie6Am0L66SdbFPAXf4zkKaumQMUsl7mmRjPCdqJAFPKngrJDwHzBydHuWqAqcpt/AfRNn+/ETXzrzln3FQCInHBcDK9JfmM6I3Gv2Tv0uYgu83iVHgFS4lfL4zua1uutDAPGqFFhKe4L0iKNDMf8qS86n5eAD2CUyBjmJBevyobppCWCRUiZ/LoPr7IzLcSlQOCYN5gDdveNDuNebilclUD2bUufBgA1E3lhBjjVUIfYRzRPkJbnagWpFO2pw3+WwPw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 21 Sep 2021 07:55:54 +0000
  • Ironport-data: A9a23:z+d2a6+n356JC1ea7AAPDrUDqnmTJUtcMsCJ2f8bNWPcYEJGY0x3z DYeDW6OM/aJNGL8c4hwaYWwpE9Vv8eEmtZrTFFo/388E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6w79j29Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgp8 u9nioTrTTsML5zVqvg+EAFVPCZhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFh21p3pwVR54yY eI0YmNudRmQaiRgJ34ZKao6teKsoifWJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev STW8mLhGBYYOdeDjz2f/RqEmevnjS79HoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc QpOoHNo9PVsshzwJjXgY/GmiCa+hDQjQ4FUL8gr2Ri/1omX+wu2AXdRG1atd+caWN8KqS0Cj wHSxoOyVG036tV5WlrGqezF9mra1Tw9aDZYPH5aF1NtD8zL/dlr5i8jWOqPB0JcYjfdIjj23 znChyw3nbx7YSUjhvjjoAyvb95BoPH0ou8JCuf/BTnNAuBRPtfNi2mUBb/zt60oEWphZgPd1 EXoYuDHhAz0MX1oqMBqaL5XdIxFGt7faGGM6bKRN8B5qlxBBEJPjagPuWojdS+Fw+4veCPzY V+7hO+izMYIZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH44owYuBV1+U3JE czAKpjE4LdzIfkP8QdasM9HgOd3mXhhlT2MLX05pjz+uYejiLeuYe5tGHOFb/wj7bPCpwPQ8 t1FMNCNxQkZW+r7ChQ7O6ZKRbzTBXRkV53wteJNceuPflhvFG07UqeDyrI9YY112a9Sk76Qr H26X0ZZznv5hGHGdlrWOiwyNuu3UMYtt28/MAwtIU2shyopb7Gw4fpNbJAwZ7QmqrBulKYmU /kfdsycKf1TUTCbqS8FZJzwodU6JhSmjA6DJQS/Zz07c8IyTgDF4Ia8LADu6DMPHmy8ss5n+ ++s0QbSQJwiQQV+DZmJNKLzng3p5XVEwbB8RUrFJNVXaX7AyokyJnyjlOIzLuENNQ7HmmmQ2 TGJDEpKvuLKuYI0roXE3PjWs4ezHuJiNUNGBG2Hv62uPCzX82f/k49NVOGEIWLUWG/uofjwY OxUy7f3MeEdnUYMuI15Su45waU77trphrlb0gU7QymbMwX1UuttciucwM1ClqxR3bsI6wK5V 3WG9sReJbjUatjuF0QcJVZ9Y+mOvR3OduI+MRjhzJ3G2RJK
  • Ironport-hdrordr: A9a23:6pO8+azAnZ9S+vO1+FTHKrPxt+skLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WBxB8bYYOCCggWVxe5ZnOnfKlHbakjDH6tmpN pdmstFeaPN5DpB/L/HCWCDer5Kqrn3k9HYuQ6d9QYUcegDUdAe0+4TMHf8LqQZfngjOXJvf6 Dsmvav6gDQM0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/jYsKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF7d2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuBalqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw3RjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXt WGNPusp8q+TGnqLUww5gJUsZmRtzUIb1i7q3E5y4yoO2M8pgE886MarPZv6EvouqhNDKWtSo z/Q9FVfYp1P7wrhJRGdZA8qPuMexzwqC33QRCvyHTcZek60iH22tXKCItc3pDfRHVP9up1pK j8
  • Ironport-sdr: mHrOAWfceGdnhFEUfhEVdWymLvnc+T620aCFtaCvFMxnDnixeVnmH0PnI6jGqzsCFUQmACpqti QxZeVmIGK4oThQ0FtwrdfYhiOH+EeP/SKnCzeAwFciPptRQQ0PJpEftlWkomnR753BXncFl27b sJRk4BQVsoTiFi+REtYLMjU2Kpm5iv0EgyKzJOBCh0LQ8lTA3HL+8mnFGxmRSTQB2/hxDLvgQ/ rq47NZ4IiO71pMdnaERUPW3Ea9aRJMrdHgxbIAFxI5IHyiiJBDy29qH/8cF6oC5Npg9vkR+nAF XFuh6bjyqHwwXOFZviJd7VVt
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Sep 21, 2021 at 08:10:12AM +0200, Jan Beulich wrote:
> On 06.07.2021 09:37, Jan Beulich wrote:
> > On 28.06.2021 13:52, Jan Beulich wrote:
> >> If anything, a check covering a wider range of invalid M2P entries ought
> >> to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
> >> control at this stage, simply remove the BUG_ON().
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> > I didn't expect this to be controversial, so may I please ask for an ack
> > (or otherwise)?
> 
> To be quite honest, I find it very strange that even simple changes like
> this one sit un-responded to for months. This isn't the only example ...

Sorry, I'm trying to catch up with reviews, but after being away so
long it's hard to figure out what's pending.

Regards, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.