[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: drop a bogus SHARED_M2P() check from Dom0 building code


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 21 Sep 2021 09:54:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xVOvEtuIVr+SUH+Eu2fBY3f675VT2BQYcpNoh9XwPRU=; b=eOn4YZhkqBAMwRRzsxfOvTDQXJy8Eofqy8yBLX6b3vXHhH8MhgJ5BtFa8NjvThAck7Q4fPMiYNCkP9Te2FZSMQyUEaxvKHRV4YWzSefi8/ZB9YIzCl1wfzfks1fWzZZ6oKgOT9coREpabubgr7E3yXjULbmxUs33/Lz7O63fDqp8SfmZcbZ1qnTCYBBGqbwGI27lnIq6/iq/JfC9eRzlJpj+KoDyAU7WYDYNztMKOVXMIlA0D8yvDskRATOgLZGwxYe1kG2w+J4UgAfRk39Cadrq8WPwWnzE3w6NC/tUXrGcLZix+wpSnuJHF3Mdtg6Z2GTrRMlnMMLLRk9YGI/1TA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8OZN8zqlsdseTvzTm8b0XVADGPqS69uc7xKnr0KckNb+FD6wj/VaaXx12YrY7HmqvguiPiYDtkSNv7wFV0o4rBrKZGtMzpDh2aSOVDluTfsmP9ax76VF8swpsMn8lyxEsJ2A84iOSbQDODOizVh31t5cpROIzLJFr+HijXnaXDReLJZo2+1zwdRw39V5z/4sMD76TB+6hGDWlcX5r/9JYc6pl7v+NoUCxxizGTkUc5I2ORHPROriSe9yZnQe4z7P3XCkwMJ/kJPxMWlEQjQpefFb2nbygvOMIEcqjj9wNOg7XUPWz/iRRUdTcTjSJ8OqJ85bV7WFcLJ/0QA9neQ5w==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 21 Sep 2021 07:54:58 +0000
  • Ironport-data: A9a23:il47w62mFr2Fn5I2fvbD5fl2kn2cJEfYwER7XKvMYLTBsI5bp2AHy zNKWW+Ea67YMzbyco12Po/n9UMA7cfdytBlGwA5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Eoywbdh2+aEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhlOAtx 9VAtYSMZB4KBZySoLwQSB9zDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIQChW9r1pwm8fD2b csJYxxUdS76W0MRInMHGMIxtseziSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc RZNvHNz8+5iryRHU+URQTWzkCKLvhMcQ+Z9Cs4B2V+1kqfP5S2GUz1soiF6VDA2iCMnbWV0j QbZxIK4XWYHXK69Ei3Gp+zNxd+mEW1MdzZTO3VcJecQy4S7+OkOYgTzosGP+UJfpub8Hy35i xuOpTI371n4pZ9Wj/jnlbwrbjTFm3QocuLXzl6MNo5GxlkgDGJAW2BPwQKAhcus1K7DEjG8U IEswqByFtzi6K1hcwTWGo0w8EyBva7ZYFUwf3Y2R8RJG8uRF46LItkLvWAWyLZBGccYYz75C HI/SisIv8Q7AZdeVocuO9jZI51zlcDITI25PtiJPosmSsUgL2evoXAxDXN8KkiwySDAZ4lkY szFGSttZF5HYZlaIM2eHbZFjeBzmXBgmgs+h/nTlnya7FZXX1bMIZ8tO1qSdOEpqqSCpQTe6 dFEMMWWjR5YVYXDjuP/rOb/9HgGcio2A47YsctSerLRKwZqAjh5WfTQ3akga8pumKEMzrXE+ XS0W0l5zlvjhCKYdVXWOy47ML6/D4xiqX8bPDA3OQr60XYUfovyvrwUcIE6fOd7+bU7n+J0V fQMZ+6JHu9LFmbc4z0YYJSk9N5ieR2niBigJS2gZDRjLZdsSxaQoo3vfxf19TlIBS2y7JNsr 7ql3wLdYJwCWwU9U5qGNKPxlwu85CFPlvhzUk3EJshoVH/tqIU6eTbsivIXIt0XLUmRzDWty AvLUwwTovPAotFp/YCR17yEtYqgD8B3AlFeQzvA9b+zOCTXojijzItHXLradDzRTjqpqqCrZ OETxPDgKvwX2l1NttMkQbpsyKs/4frppqNbkVs4TCmaMQzzB+MyOGSC0OlOqrZJl+1QtgaBU 06S/sVXZOeSM8T/HV9NfAcoY4xvDx3PduU+ORjtHHjH2Q==
  • Ironport-hdrordr: A9a23:GLNRFav67bzJauL7NcBl5BE07skC54Mji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLnAbV0gj1XYANu/yKDwJeOAsP+teKH Pz3Lsim9L2Ek5nEfhTS0N1EtTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqZmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87ysIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXoHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1nackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMG9yV0qp/FWH/ebcG0jaRny9Mww/U42uonZrdUlCvgglLJd1pAZGyHo/I6M0rt gsfJ4Y0o2n46ctHNZA7dw6MLmK41r2MGTx2VKpUCfa/Z48SgfwQr7Mkf4IDbKRCdY1JKVbou W3bLofjx9qR37T
  • Ironport-sdr: YUz+NhDjEIic84pvVGQ3L/NtPgzrI8euDWZbeANmOq+yv1YQvWdzVYMhiaYgXy83F9nzuBgEX0 zY27f2azEvna8OlcEtZ39bZoffLlwyv29D+xiyAEQGxXutn8gI5p3loYXaPnqsZo2sJEO9NS0+ Y3YlxnuZIMCpUC1uowimz4gqas+US/RF3HxGIcvaeeQd0PwXfjuRnC2Hf1MEX3AD86XePbh8Vp X+eG02KrVqmwmP4eQzjzvh8/2QI/5vUzZrwAHN8MHWa73tlEUcfC8Fsu4gESSKzbI5Y9xWVsKR GdiTsOBR1ygnXQ3UrnkUmleT
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Could you explicitly mention PV somewhere in the subject?

On Mon, Jun 28, 2021 at 01:52:52PM +0200, Jan Beulich wrote:
> If anything, a check covering a wider range of invalid M2P entries ought
> to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
> control at this stage, simply remove the BUG_ON().

AFAICT adding this BUG_ON was a wholesale change to protect against
shared frames, but I also cannot ssee an scenario where we can get
here with shared frames in the m2p.

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.