[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ping²: [PATCH] x86: drop a bogus SHARED_M2P() check from Dom0 building code

  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 21 Sep 2021 09:58:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5SdVMlKdK6Fp3DvkmECiR7cppxy477qPRMs5PbUQaJE=; b=WWtzBhb03fS+mmXDHcYeb2BwARV/9ujQ+cD4QUI0jTGVooSEyCwO91eCqZ3WIRIRV12BruNfTIix2ETRJCQUZAHrplyHybgo3MiFKtFj1GnSeOTbDWZFHDepSTxCcs1PxCIL0OmDkUeog/ontYcTYR8RtWlm7a0/dliFo7YlnLlVCCAJM/1JjGhvr541Dk8c6VlhnwInGmV+3ZLphV+kkrZzUTayued4h2Znx1LeySXaFmiuIuwTIg9bkz7Rf9E4yPAKjiitG/y2VPvmoBPClFNC+SlLCCMwQCcQHHsTzb6liTqOxgWEEJxelEACHba7oP1GtXG19ZmKAFSzWgjROA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6Ft1wh7xHVu2uM9YUNOmD2KTD5HvMhF4yDrS2JBEzjFzB1R3K850GNuhWqSAiGEo956WVBPWjk8Rx9+yleKkBqweWE/BHQzNz+odE59Oxy0gW6i44vbjN0aIs7TIWOYAH3RhOXhxCK/t3XGHfgBwHWvP/pkisFJPBdDDZ8iZyOmFc5ek+DVI8fSSbs6evSA+xTtlRtBWgtUtDO4WjzI7/wP9v380rg6y9AiX1uzl4dwkSBYYXVEPQ2u0o8elmgt5NpC3Mj6r4O1dYm6EqrRn2YOY8yN7asueFPw5csGaQmTTJb78vetC/io1ACiciYy4G942g7QBTshvjys9+50vg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 21 Sep 2021 07:58:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21.09.2021 09:55, Roger Pau Monné wrote:
> On Tue, Sep 21, 2021 at 08:10:12AM +0200, Jan Beulich wrote:
>> On 06.07.2021 09:37, Jan Beulich wrote:
>>> On 28.06.2021 13:52, Jan Beulich wrote:
>>>> If anything, a check covering a wider range of invalid M2P entries ought
>>>> to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
>>>> control at this stage, simply remove the BUG_ON().
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> I didn't expect this to be controversial, so may I please ask for an ack
>>> (or otherwise)?
>> To be quite honest, I find it very strange that even simple changes like
>> this one sit un-responded to for months. This isn't the only example ...
> Sorry, I'm trying to catch up with reviews, but after being away so
> long it's hard to figure out what's pending.

Thanks for the ack, and I know you're still catching up. This wasn't
primarily targeted at you (for this reason), but it also wouldn't have
felt right to not include you in the ping.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.