[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] common: guest_physmap_add_page()'s return value needs checking

  • To: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Sep 2021 16:47:15 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TsZfJ/e/HjHx9vRm/4cDVIru8+MI9qsCuRKIHFtqCLY=; b=W4P8EPuI4pWz/xCVXQPY9PfFNFHFpXvuIKOgAf6sCQ7jDSs8JfDPRGXnAz8J3clRiTzV3pSqaHvynP3wmg7TctpydtuJwUz4VkFaWjefwkt5AjeKIqoiSPOdYPJqwH4hrVpM320sE7lVeonIwmcId1nmWPtTV1f+gM+aBssJgSgl+/BAyaEw4bHt0/h+8WLauXUXYyiCBdUTAWGYY1lDPjYQz7IcVdiIuSI7X/wtbEXE4h7jTZFV0ndryDkNBaD2Vzx5t9LvZ9ePdR4YXf3f/CdGAiZbNcYs70nExnIDmlkGfQEQXJz6Ha7HofIHfxCIXdn2KkcTyKN+4gJ+ECw09g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdU5S+H02fY4dCdvfDEWO3C+FBNVGDQsikWwy3QuFcctShXzecnZrMEt5hax/KPIHso6igvWzN9jO/2AxFluIp2mp39QcYhx38AnzlycDDbRf+pwUd9zBtr0l0g5gsDS0KzA2U+1rn6vNEmFlktgzkCkC9NAf1Fr1Sg4v3evcPpHT1HuFMIZULr7bowI4HtdMbJwXFBarYRqUa/uUJG5dqL1FihqJfGx7IF/XjJnImc8AktB+A8nnseBvINewmBCcf9cBu0WaXbK0YPJJTKN98ogNhtV+UFj/7cyXFpxpIaVHYgNyq08WcETB/oT2cmbqO7BS1ywzMmZ7YWSFb9K6g==
  • Authentication-results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Wed, 22 Sep 2021 14:47:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21.09.2021 12:49, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH] common: guest_physmap_add_page()'s 
> return value needs checking"):
>> On Tue, Sep 21, 2021 at 12:28:12PM +0200, Jan Beulich wrote:
>>> On 21.09.2021 11:20, Roger Pau Monné wrote:
>>>> On Wed, Sep 01, 2021 at 06:06:37PM +0200, Jan Beulich wrote:
>>>>> The function may fail; it is not correct to indicate "success" in this
>>>>> case up the call stack. Mark the function must-check to prove all
>>>>> cases have been caught (and no new ones will get introduced).
>>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> Thanks. Albeit strictly speaking an ack here isn't enough for the change
>>> to go in, it would need to be R-b or come from a REST maintainer.
>> Oh, FE:
>> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

With these, any chance of getting an Arm side ack here as well?

Thanks, Jan



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.