Re: [PATCH] common: guest_physmap_add_page()'s return value needs checking

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 22 Sep 2021, Jan Beulich wrote:
> On 21.09.2021 12:49, Ian Jackson wrote:
> > Roger Pau Monné writes ("Re: [PATCH] common: guest_physmap_add_page()'s 
> > return value needs checking"):
> >> On Tue, Sep 21, 2021 at 12:28:12PM +0200, Jan Beulich wrote:
> >>> On 21.09.2021 11:20, Roger Pau Monné wrote:
> >>>> On Wed, Sep 01, 2021 at 06:06:37PM +0200, Jan Beulich wrote:
> >>>>> The function may fail; it is not correct to indicate "success" in this
> >>>>> case up the call stack. Mark the function must-check to prove all
> >>>>> cases have been caught (and no new ones will get introduced).
> >>>>>
> >>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >>>>
> >>>> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >>>
> >>> Thanks. Albeit strictly speaking an ack here isn't enough for the change
> >>> to go in, it would need to be R-b or come from a REST maintainer.
> >>
> >> Oh, FE:
> >>
> >> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > 
> > Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> 
> With these, any chance of getting an Arm side ack here as well?

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>