[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 8/9] x86/HVM: skip offline vCPU-s when dumping VMCBs/VMCSes

  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 23 Sep 2021 13:27:30 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vykuahmkcVEa45h5O0kikFNVm23Ro8CWi14oldtTsS8=; b=cezzSvsFj7POJ8C1jmmOZQ0TgBXCFhgsM6AuxkaynfP5D6Iv+rE0+gMl6AWS9+prk3QdCEV66HERO5UF5tdmM2mGGIWzemPHyLgwzXD4M5ZiLR3OocRln/ERXb/CU1tcXfQmnz1gsQh95WdG0GFJIcoqHBv/5J3WsvVdNebPAtGE5AVgvBvP2gDxVDGuT2WgR6Pjz7To3KGy3Rrsj1u9pmhEfS0kiOqQ1KawOpeZ7FUKP05P6ldilkYKxuZICwxEZQeBbrq9qPb/e0g5YgwfwsNKl71lJALyGmv82w5tqVMjBxNP22mFaq3XAYjMSZyjsovYamb41MJQn+biObpIkg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFy9sZcAmNbRUznYTTWXyi8z9eaw6BO2giM0KY5J/ROsF9CB0a27Vw02m8N1esVgMaUOXN2WkjSNb6ORfm9yOOz2QdVLQWSRkvSZ7n95exKorU7xRI1r1h42IiqA5EIjIqx6pHIN99ONxqf14yeJx3waPzxdy8+F5aVKRrXAEh+6VQns6D2uaJFIcmEAvCjJEdXUHeRm5IBxIClaaMiNUX7ALBjBOCulrzZ9CnABgioUKqIghjjw1sU2u7VAWR1H3alHY8MerwbFNuFj6FqPRE3KmFIIrgy2wa+z1uXhGRdz1MsHtTH/+f9CPokGp8WD8etGhijZ1evhJtBzvCuo2A==
  • Authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
  • Delivery-date: Thu, 23 Sep 2021 11:27:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 10:23, Roger Pau Monné wrote:
> On Tue, Sep 21, 2021 at 09:20:32AM +0200, Jan Beulich wrote:
>> There's not really any register state associated with offline vCPU-s, so
>> avoid spamming the log with largely useless information while still
>> leaving an indication of the fact.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>


> Is the state cleared when the vCPU is brought down? Or else it might
> be interesting to print such state for debug purposes.

Hmm, if that's considered to be potentially useful, then we'd need a
key different from VPF_down. HLT would leave state in place, and the
INIT/SIPI sequence would clobber prior state also only on the 2nd
step. v->is_initialised may be an option, but gets cleared by INIT,
not SIPI. Any other ideas?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.