[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/37] xen: introduce a Kconfig option to configure NUMA nodes number


  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 10:55:51 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oVQQTPXxci+0Cg1D5M+tpUegLfCxCcaSTPoNvSXUPpw=; b=ZkkAjew49PnH3QLtRAHKDissVwDe/tGqdAvQqouTVggKMNGN6xVysbq5whiE/DXEp3KSNg3p7E7wKORly7sHBHnPM3yKkQU6Favxv9ikp5VNYM0kskC9TgLpF6547Ufkj2I2cLv1xm3LlNFl5XXbx9xT2g1mCfD3iAk+cNcnItrQlVzZNpt4eynIsv5A17EOaJMlkfTa9dmnhwN2gb1rEVduR9mazlsuW9KeC89W2Ut4JjaXGywrlBGihVvayK/8MSlmao2t918cCXNASWB8CBguFIXyXuFki6xER9yZGdI+n89kqAjJJGU3G6YkVUqS6NwgAQJ5VS7ZHMsLSMZMRQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVc/JlSz+BOOldySCKMvYXOOHFIx9j3tzq1cK/rJf8110VMtJGb9+KF7ho5PC8/lSa3pDKKCKDqFTxxx8hdw4vuQHsX+83bL8+kB+y96UmC8mPKGJqqkEpb7xnSL2GfiPy5CPYktRByJ6ODy8k4XqUH2Aga3bab4hr/O3Q2ArUf4ZWlZmMvydIwCFd5XDpyTzs3Z8OmSfccHQcnBtVR8AHffUyKqru0sJG24SrMS7hBa7WOLmMvY58jDwj59WlbpcM9AW3LwdmDmFiI2aH24cLQ4igJS7HKjZl6JnPs+RqJ1+iHt4U09GoHZqfwDI/toiCfndbkZbxiFtGi3xPXj4A==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
  • Delivery-date: Fri, 24 Sep 2021 08:56:14 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 14:02, Wei Chen wrote:
> Current NUMA nodes number is a hardcode configuration. This
> configuration is difficult for an administrator to change
> unless changing the code.
> 
> So in this patch, we introduce this new Kconfig option for
> administrators to change NUMA nodes number conveniently.
> Also considering that not all architectures support NUMA,
> this Kconfig option only can be visible on NUMA enabled
> architectures. Non-NUMA supported architectures can still
> use 1 as MAX_NUMNODES.

Do you really mean administrators here? To me command line options
are for administrators, but build decisions are usually taken by
build managers of distros.

> --- a/xen/arch/Kconfig
> +++ b/xen/arch/Kconfig
> @@ -17,3 +17,14 @@ config NR_CPUS
>         For CPU cores which support Simultaneous Multi-Threading or similar
>         technologies, this the number of logical threads which Xen will
>         support.
> +
> +config NR_NUMA_NODES
> +     int "Maximum number of NUMA nodes supported"
> +     range 1 4095

How was this upper bound established? Seeing 4095 is the limit of the
number of CPUs, do we really expect a CPU per node on such huge
systems? And did you check that whichever involved data types and
structures are actually suitable? I'm thinking e.g. of things like ...

> --- a/xen/include/asm-x86/numa.h
> +++ b/xen/include/asm-x86/numa.h
> @@ -3,8 +3,6 @@
>  
>  #include <xen/cpumask.h>
>  
> -#define NODES_SHIFT 6
> -
>  typedef u8 nodeid_t;

... this.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.