[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/37] xen/x86: Initialize memnodemapsize while faking NUMA node

  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 10:57:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=O0+qqISdYcBc46T1s3IsLnxBbWiKFt4J3XldhYnLsKI=; b=iH/wi8Z0Z2PVXcXnPilvPWtJTyThhRsz/9514a0euJ9TVyylyFG/NIyK+rAjyl77c8n7K7jpsjaZNR7FDNM8fbAAjAiUHfP1oX+JUgpV36p/cKusaetFSFOgzhh2E06PLFPYnfkDt5Ac4U8hYWETjs09oo8QOZ8APfVnQHVqUXGUWRSC04OjDpp3oITHeoBJqsvYmFGNa+YtVVRvMY9A52sN4GO8dX8jxj4gHwGtSq0HbgzUxT95X8Df894utIgYt6iQLbJerSJSUcCtyN7ab3wPsCH2hL4GtofvdYF6spptyNllv6b1M6MOg2d4XUgGMYmU8KXfDNqRiWUGwUzOhA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oAIm6kD10/5aOGVDuD3dKBGMNJ0ycHk5y0zefr9QjnWpC5qu5TKz0aDhmDAcObeNkHmMMTY+ajtDQUxx5z0oQA3n7/qJr9ulcUTazAf4Dozo/NoTp4Qm09+wQTCG1GW+bEf+Wyp6n2/1XTLxls8e/1IZfJJ5PkDaG/VQbOrDnCh2bYwr/SLJ7WiAL65RqWXZqd5uSiLHVXArBG+ewvkg7CY4LHMtxLqkPvikUqZWSSkZb3G31WbckK9ZD9vXJmLWD0wGUC99jkv1kktx+yQHLPczoh5SLQo7lb+QSzLj/HR8WcCUCHDpc4Hzwn+HtBcPBSdVcY5pP8XLoyKnoUfK6g==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
  • Delivery-date: Fri, 24 Sep 2021 08:57:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 14:02, Wei Chen wrote:
> When system turns NUMA off or system lacks of NUMA support,
> Xen will fake a NUMA node to make system works as a single
> node NUMA system.
> In this case the memory node map doesn't need to be allocated
> from boot pages, it will use the _memnodemap directly. But
> memnodemapsize hasn't been set. Xen should assert in phys_to_nid.
> Because x86 was using an empty macro "VIRTUAL_BUG_ON" to replace
> SSERT, this bug will not be triggered on x86.

Somehow and A got lost here, which I'll add back while committing.

> Actually, Xen will only use 1 slot of memnodemap in this case.
> So we set memnodemap[0] to 0 and memnodemapsize to 1 in this
> patch to fix it.
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.