[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 03/37] xen/x86: Initialize memnodemapsize while faking NUMA node
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 24 Sep 2021 10:34:15 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fkc19n3/f09++KXFEYT/F+y3BGSBmy0DKrhefV9sAgE=; b=W1jsXSV9ETXwzRvYU2GIw8Tt0ciZRPvOWXDMAdFn8YsDJVzW8m//mw1IGYXNllducxoE163xgqhSy+72RFWCMkkLePSBhAZMlWAiYemz9hN7FUs48nFqPk3cEsb0Y7AeDnRMKtA/Q7tfnm33H/bjkX2GsIJ8TA9IOjVZBLuID/wT18qGo7zQiN6G+s+7QDXUpu68CT3aPURmMzDsh11gZyOg7uUuJxV2H9SJh4yaigLXSwnhF054IDdk9lnbNzxZGUZdMWYuDNlBB87Si3ZMyrl1Z+ZEvI1WcS9D1iraaIvX+mJi0S1QWt8RjrvqooIE42dr6kbxy/ciKCpuRmQX3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GnqMGs2MOW4FFM04zVLJUJzqrzfBv4hn3fU2/ZeSnLaW/FiJAqRZLBJoTjdHcqp/sJdudkfjo8POFdWl9ZArk6CEjIbnfU7LEzSn2mAYOukI45AZPhaDFqqUrRxkqrIVX9qDxQo8gI8oTIuh8ipV7sYftnDTkqxli+hzPaBbx9AXQBOODAtQRSttf+Tvkg1bpeyOSxX2OfcZM48lkLMBIapMD8sUgvrTasSN6exlTBbHrykB8Bg935YySWpdFSwFaBvtMp5jkbA8noG9JNYcqLruChyvGxkrwrMsqx8TtaYAlMDq2q21kTPuTRVc8hb42eloSqr9HEr37uXMhVN12g==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 10:34:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHMIJLEC2+fmVEC3A6RnJgdqV6uy43iAgAAa/qA=
- Thread-topic: [PATCH 03/37] xen/x86: Initialize memnodemapsize while faking NUMA node
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2021年9月24日 16:57
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 03/37] xen/x86: Initialize memnodemapsize while faking
> NUMA node
>
> On 23.09.2021 14:02, Wei Chen wrote:
> > When system turns NUMA off or system lacks of NUMA support,
> > Xen will fake a NUMA node to make system works as a single
> > node NUMA system.
> >
> > In this case the memory node map doesn't need to be allocated
> > from boot pages, it will use the _memnodemap directly. But
> > memnodemapsize hasn't been set. Xen should assert in phys_to_nid.
> > Because x86 was using an empty macro "VIRTUAL_BUG_ON" to replace
> > SSERT, this bug will not be triggered on x86.
>
> Somehow and A got lost here, which I'll add back while committing.
>
Thanks!
> > Actually, Xen will only use 1 slot of memnodemap in this case.
> > So we set memnodemap[0] to 0 and memnodemapsize to 1 in this
> > patch to fix it.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
|
