[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 33/37] xen/arm: keep guest still be NUMA unware


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Fri, 24 Sep 2021 10:23:05 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=f7Ys0AlnPPVo+qE1SrJrFiZ+dpPJsmWm14CcFfyelW4=; b=Yudf/yQqINIueVuj77ENZwjIMDEAvOXYqpDFWaR6Y2XhAnrxLlwNes9Nf5wm1+sh+UTtxO1/4GvaS98Gxajcw83rRabTe7xnjk9HtsHm9fYXKypjk6R57uRJzF5Cn/PmrlU/Idt5aMDluYqcaGaJrHbY0pWTO7ZCtQujyodu6mjSbz2FRvUC5rzYsvAEHUWXPW6CH8+aFpuNp0q9+Gk0OrVX9Uu0BjzpKkG0RCKBQirWxWdnNCsW/ZvwA1newFy8oIOptBOGtj6nq1gTHNaq4dNYD05CyXXmurYjM6dFG09Lw7ZogL59OEwpOtRVOJaliLlKrON0H4rTOAGsTccTpA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wl9yX3EswmhQ1GQzHRvkVl4gdAssJ+7rGNnJZS9s4h9WxySmsc9TrcpjOOYwfXAMNINR/lBLGKA+QOrYANs4G+IeGz3AzL9NWOm7EkQn+6hgrawovVg2CBU3nCvyd3fkOVCspfEFpor8jeNQqA3Bt+VlX71aXf4nSFmpFLu0qN5M4xYWPD2pPE0qZafPc52gCXiMp8ExoEQNEoTQPoqVPmCn806N65BuqC5dv+mC8/D60OlJvtHqDIxbypvOsU+uGLh0l8vHA2sw/fcgDlPC5m8qtWnT8x4sSnah3nokOAz70CKs3ZUyhm0AtYLxnkBeg6ehCz8lHzK2+ezg45HjAA==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Fri, 24 Sep 2021 10:23:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXsHNOacjZjYh6d0ebH0gUeyb/WauyhQiAgAB2NnA=
  • Thread-topic: [PATCH 33/37] xen/arm: keep guest still be NUMA unware

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Sent: 2021年9月24日 11:19
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx;
> Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [PATCH 33/37] xen/arm: keep guest still be NUMA unware
> 
> On Thu, 23 Sep 2021, Wei Chen wrote:
> > The NUMA information provided in the host Device-Tree
> > are only for Xen. For dom0, we want to hide them as they
> > may be different (for now, dom0 is still not aware of NUMA)
> > The CPU and memory nodes are recreated from scratch for the
> > domain. So we already skip the "numa-node-id" property for
> > these two types of nodes.
> >
> > However, some devices like PCIe may have "numa-node-id"
> > property too. We have to skip them as well.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> >  xen/arch/arm/domain_build.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index d233d634c1..6e94922238 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -737,6 +737,10 @@ static int __init write_properties(struct domain *d,
> struct kernel_info *kinfo,
> >                  continue;
> >          }
> >
> > +        /* Guest is numa unaware in current stage */
> 
> I would say: "Dom0 is currently NUMA unaware"
> 
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> 

I will update the code comment in next version.
Thanks!

> 
> > +        if ( dt_property_name_is_equal(prop, "numa-node-id") )
> > +            continue;
> > +
> >          res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
> >
> >          if ( res )
> > @@ -1607,6 +1611,8 @@ static int __init handle_node(struct domain *d,
> struct kernel_info *kinfo,
> >          DT_MATCH_TYPE("memory"),
> >          /* The memory mapped timer is not supported by Xen. */
> >          DT_MATCH_COMPATIBLE("arm,armv7-timer-mem"),
> > +        /* Numa info doesn't need to be exposed to Domain-0 */
> > +        DT_MATCH_COMPATIBLE("numa-distance-map-v1"),
> >          { /* sentinel */ },
> >      };
> >      static const struct dt_device_match timer_matches[] __initconst =
> > --
> > 2.25.1
> >

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.