[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 36/37] xen/arm: Provide Kconfig options for Arm to enable NUMA

  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 12:25:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IWDsTB/XrnmD4UkTyPlFg9JMBb+0jAMIBX8dFfssLRM=; b=bjzRERp5LUFZnlA0j4w/3woOICe0Tr7gUk9f+30z2v89uOT6g6PYMG1791V2PRKJ7bpg7FgyY7yrAW0O0JufxriuOOymlbopxCDmF4bz5eyhpEe75BRZLnhtJpljbVzLENrA6raVuo7efB6PITvsI2tUSuUSM87uFHkrlWvzrygVBISvQI64oe2XkOT+mZhOgUadM3Ky6/qTY0YldHeNKr3YqztdOwsiNL1kFvJUVNpmvvvdk56VOfmr8vv5fAb4vSzb5aTkH98QLKQvcG1We/D/knTBNRQpYuQhT38g3fJHpLVSnd1nEreFBthJ02SReLxF4mMr8fU8dr3w54DjTw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jvay3FowmX6zIIQXRijjnvdekZZwWmyPDRuxd71BeyV49CviMPNzA6M3RqNfpUpn1qciznz6NEyvhMriQeyb26T8rg3DaTxVTkSTugKW8dJ9ouZqHql4nEUjYfg41faESFrCasRr9L3BVcJE/xz23SGrOOZpXYUrJyN8jw3s2iTpQZDoJkyyCW1EwwhUCUOlAd7ICDnf4DwhgcaIb5QKtRVDMbRBU5Ww3Rbp7XjCtIkPOo1+pXBkMx4WipDoZRpf5w6Y6KlLVMtDq7eof7R9b77VZxKt3qlzL+q5Z4ALQwk1edQYrwlZ74XSZeOXn9tPHiicubcH0ZP5XuKMs6wGnw==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
  • Delivery-date: Fri, 24 Sep 2021 10:25:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 14:02, Wei Chen wrote:
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -34,6 +34,17 @@ config ACPI
>         Advanced Configuration and Power Interface (ACPI) support for Xen is
>         an alternative to device tree on ARM64.
> +     def_bool n
> +     select NUMA

Two nits here: There's a stray blank on the first line, and you
appear to mean just "bool", not "def_bool n" (there's no point
in having defaults for select-only options).

> +config ARM_NUMA
> +     bool "Arm NUMA (Non-Uniform Memory Access) Support (UNSUPPORTED)" if 
> +     ---help---

And another nit here: We try to move away from "---help---", which
is no longer supported by Linux'es newer kconfig. Please use just
"help" in new code.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.