[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI architecture

  • To: Wei Chen <Wei.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 12:49:22 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pLRBaqlOdRpvHdVYmUYhZb1e4XBqWWZzrnIW7aIUZMI=; b=ZNUmKxkArVJWMp1wYfnDc2RVNI4T2GE35j0ZdeSEDP6oQ6bxh4SQaNLAqX7pdXluLX8gfPRWpY8uScvIkH3yamTtPgZqF7BD7qx8wWKoEt/Cg1QvEiXjtIH5O7cckAAOcS8V7NVmmtkoHzrW+QGHtI9L8W7lJEODfwE10LaNmt0w4+5wXwqXn5Ap+8nv7/ZlbFumcYePGZ/cyAhELFPv8OYp4n2XAOI5/qthGIG3IE88annifiYAOHkiJUdVYah9IebBsjsT9HhrJQRJL+vA/SWBA6cKQuaJ9wf5T+kauDeSQupRlB53dos8shZyNjo8vi3d4yrIUD9W0TVxflOKUw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JZD7ROh4zTHI5cwZjHKVwArR1L+UIRyJ8XJNwdm5KHvz4dXTN9bKU0Ns9qfmqnVj4LY24KI+yKKjZMfTRj36vN37upAK2NAvL4V4aWedKHPKFdaIqR0Py33LWO2WWtuM8Phw8pwsaCYrj4JudujB2ngY/4hoW0i/G3D6UZ35JgpsWC5gMx2PdP9teyo2GW87WEqTskX28AKa7n9Ez42K6NB4WFCkoL8qFpizRImg85C5ZSJ2wvOBkzHVdT0iNRwEgdLhpvoIONvcE3iJDOGvHrW08bP/9bpFcSFOeACTdrKjg+XqjoB7cMupRr9wa5qnFE5BJkW35mwjAZXGohLpDQ==
  • Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 24 Sep 2021 10:49:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.09.2021 12:31, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2021年9月24日 15:59
>> On 24.09.2021 06:34, Wei Chen wrote:
>>>> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>>> Sent: 2021年9月24日 9:15
>>>> On Thu, 23 Sep 2021, Wei Chen wrote:
>>>>> --- a/xen/common/Kconfig
>>>>> +++ b/xen/common/Kconfig
>>>>> @@ -11,6 +11,16 @@ config COMPAT
>>>>>  config CORE_PARKING
>>>>>   bool
>>>>> +config EFI
>>>>> + bool
>>>> Without the title the option is not user-selectable (or de-selectable).
>>>> So the help message below can never be seen.
>>>> Either add a title, e.g.:
>>>> bool "EFI support"
>>>> Or fully make the option a silent option by removing the help text.
>>> OK, in current Xen code, EFI is unconditionally compiled. Before
>>> we change related code, I prefer to remove the help text.
>> But that's not true: At least on x86 EFI gets compiled depending on
>> tool chain capabilities. Ultimately we may indeed want a user
>> selectable option here, but until then I'm afraid having this option
>> at all may be misleading on x86.
> I check the build scripts, yes, you're right. For x86, EFI is not a
> selectable option in Kconfig. I agree with you, we can't use Kconfig
> system to decide to enable EFI build for x86 or not.
> So how about we just use this EFI option for Arm only? Because on Arm,
> we do not have such toolchain dependency.

To be honest - don't know. That's because I don't know what you want
to use the option for subsequently.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.