[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] include/public: add possible status values to usbif.h
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Sep 2021 10:27:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4FJpTFZ8F6mjIpt0KUVzZy0+zeEyXsMPTLCOwRbaFdI=; b=XDAapQAPdS3vkQxeL4mjm2/Z3ZQ54VHV1wzVwN2Pc/B1JstU+N06UTaE9bsxVpqQSloPvts10lLMkEQxgmsTeEu9JuF/O4xlfKNegE4KqhqIeKUX0xV7W4JWza5sdSsNd9F0mXPizH61gjrxs5krE2qz44V3UCuB/nPBXIv4M+nDFc7dPeHEBlb4Jg8ZlODNMrXRudWXit2ms/YHszjTqkmsvV690TcqoKeiVjqbY6hL4BopfLAJahOZuldDYiSXNnotM2PrINwI8KeNgJX5WWGMKE2Z6ziieGwtQ7odJOOoi59k5PNeBu0TQhmt+JadIGZF6EOUlzscWNCOjM40Gg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IHkFGTM8Im4iS8soP9Nl6sdLVWdlkg/sVZFK2lWeMU836iB8UaIlblw0mnETTjvK4+ISZgQYDUvKk61VtzyfTnNKeLw2DptfQBxB5q8bILQSNBTsV65CGmpS5onALF2EFWAobslNpQmaLldftFABqCQnBwPfB/RkkX6i7rK14bwEh5DvVFbchvl1qRWoJJeq0g6ghXV8KhcBaFrZWigPdvCLGed1HIWIQ8FhalEVOykcLPjh1stY8GwsAPLlvHgSzEthqm83el7NCXTbYNh1Zg1iADE9RgoNFfKuvnAfTjeY3SdU7NPgngY6p1QGq6B07mM17Vn5jANzhmqcD76UVA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Sep 2021 08:27:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.09.2021 10:20, Juergen Gross wrote:
> On 27.09.21 10:13, Jan Beulich wrote:
>> On 24.09.2021 17:04, Juergen Gross wrote:
>>> The interface definition of PV USB devices is lacking the specification
>>> of possible values of the status filed in a response. Those are
>>> negative errno values as used in Linux, so they might differ in other
>>> OS's. Specify them via appropriate defines.
>>
>> What if new errno values got used by the driver? Would we alter the
>> public header every time? Or is the likelihood of further values ever
>> getting used vanishingly small? In how far would it be possible to tie
>> these to Xen's public/errno.h instead?
>
> Those are the current values returned by the backend. Other ones used
> internally in the backend should IMO tried to be mapped to the values
> defined in the interface specification.
In which case I'd like to reword my question: Is the set of values added
sufficiently rich? There's e.g. no ENOMEM equivalent.
One other observation: Why is this header using tab indentation? This is
by far the largest (albeit sadly not the only) of the style violators in
xen/include/public/io/.
Jan
|
