[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/11] xen/arm: Mark device as PCI while creating one

  • To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 27 Sep 2021 12:00:52 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3QPHlbDmOoVFRDmyzTvu3eGnri1US6M7NCW0Mn9uJVg=; b=B5HCpACQC8dL0SYMyycn6bcutVSl4YymYZqivQ8hQheG20CUkvMyNF0I/Pqnh3trBII3l86Fs08qlctgoT4hrAxhELdLuL6xQglQLA+ICpVrRB8ZJxhchcqc8nYY8RtoXgsbK2nQt2Mhlnhx/HeiE1wUfMDgGRVOGtAozFtWN9weC4HrfF/kVMIJhO4sqmwfuFz2mxYg4J/kHwn4Dmk/tuvdyFF011jbu9yTvD+E/9UCrxl6Cv35ZBdLdGOCsFWAoy8GOqjTJ8fUqkEIGWMkW1z1zrULsI2Tiq56b/7uX5r+tdhlfS/pAK+u6T11nbFYkpDzSn6D2XDHQOUopPhIzw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGRZhR9mbrSO9sfbctRfqWtlj2qBArFn3FU2gTfr6cQO1GtCCxq0hY2TlaHdQypNcxK9Afy3XiEMLpWZjZhKk2zosao/8a2KCAfIvhxMOslPbAQYlmXhREU9HwtSqGJ8cMjDS9Ft/uTmy/IsEhFkdY1QQBaW7fyz7hvnRygDKkL3u2q7R+lkg680ECwnlOhcJgPj0YaHDZ0DvKHfosxMdwFk3gbTmcQXfJHySOqJxfW7ZCWwfAONtJLjxtKo3JXRSYC3zBpfVsh6uw4RlJjA+JTG6Bgwkuz9IeekHzS6Dj9dHZ1WBoaGzhnYntMWMUbY4xoNR7U2DWJzXxDnEwMWIA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 27 Sep 2021 10:01:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27.09.2021 11:35, Oleksandr Andrushchenko wrote:
> On 27.09.21 12:19, Jan Beulich wrote:
>> On 27.09.2021 10:45, Oleksandr Andrushchenko wrote:
>>> On 27.09.21 10:45, Jan Beulich wrote:
>>>> On 23.09.2021 14:54, Oleksandr Andrushchenko wrote:
>>>>> --- a/xen/drivers/passthrough/pci.c
>>>>> +++ b/xen/drivers/passthrough/pci.c
>>>>> @@ -328,6 +328,9 @@ static struct pci_dev *alloc_pdev(struct pci_seg 
>>>>> *pseg, u8 bus, u8 devfn)
>>>>>        *((u8*) &pdev->bus) = bus;
>>>>>        *((u8*) &pdev->devfn) = devfn;
>>>>>        pdev->domain = NULL;
>>>>> +#ifdef CONFIG_ARM
>>>>> +    pci_to_dev(pdev)->type = DEV_PCI;
>>>>> +#endif
>>>> I have to admit that I'm not happy about new CONFIG_<arch> conditionals
>>>> here. I'd prefer to see this done by a new arch helper, unless there are
>>>> obstacles I'm overlooking.
>>> Do you mean something like arch_pci_alloc_pdev(dev)?
>> I'd recommend against "alloc" in its name; "new" instead maybe?
> I am fine with arch_pci_new_pdev, but arch prefix points to the fact that
> this is just an architecture specific part of the pdev allocation rather than
> actual pdev allocation itself, so with this respect arch_pci_alloc_pdev seems
> more natural to me.

The bulk of the function is about populating the just allocated struct.
There's no arch-specific part of the allocation (so far, leaving aside
MSI-X), you only want and arch-specific part of the initialization. I
would agree with "alloc" in the name if further allocation was to
happen there.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.