[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v3] xen: rework `checkpolicy` detection when using "randconfig"


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 27 Sep 2021 12:03:49 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JYRPyskItNKUUBpdGX7fZkaIYIjBrv5rwp9aY6ntDVI=; b=Bi75LK4LhhxRCOmNxozkhBnsf3WZEcwhgZQIeBcNY8+gJYvyziaLnCo4MFeNF/YouJC291wyHGarl07gM3W0fkI+knRVD+gCRzWCGIWmrsnIyf8aNAUpWUH/5e04QDhK3K4dQqnfZfAt+T1qZjEHAKv6JlWoUdwBY7Rlmci8N7FaWegHBTOmSHBUaiAO+/tf+gAI/pTjmiU/L4rofAa6DCZprHdoXt3RzJ6wDshx/XYdr4eVWSbmVznDTo/oARbySj2IPOBmdnQQLszEzugpAgFpq0sYH/pjCLhh5/ozVgQtdH2f0VvBdvV1INXT6ISZo5NQOXo07PPsEgTx53iIDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZ7h5QuUlnjq5y/3D0u5JvgJP7wQL62YgGAEnf7SgNjZ0unBqe9A9S3k5sWkMQS0YctEMqtVZsyJwpJwhTwEHeyVXkdsGVr9MuuFn1qkPMa6lMhLwWO1eleUQ/0cgR+6EChBBiAPg3B+ykuh7d6+Bb7yofIDqZl/H6et3JT94g4EoONUHGDyTsFHz6vmSKwkBXigcJBAEDbqJSw9asNlWdmtH0NhhB51++fgIWZrwyHybxmn1+4q+wpsMYjcO58Jn5PwnUzewtxyfvKTunBxp5qiEGZPZciSH0R0mfC78ePHQfdypMGR1heZt5Ya3qPjwyu68BazYORD948SzxvO5A==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 27 Sep 2021 10:03:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27.09.2021 11:46, Anthony PERARD wrote:
> On Thu, Sep 16, 2021 at 05:34:00PM +0200, Jan Beulich wrote:
>> On 08.09.2021 13:17, Anthony PERARD wrote:
>>> @@ -189,14 +193,24 @@ ifeq ($(config-build),y)
>>>  # *config targets only - make sure prerequisites are updated, and descend
>>>  # in tools/kconfig to make the *config target
>>>  
>>> +# Create a file for KCONFIG_ALLCONFIG which depends on the environment.
>>> +# This will be use by kconfig targets 
>>> allyesconfig/allmodconfig/allnoconfig/randconfig
>>> +filechk_kconfig_allconfig = \
>>> +    $(if $(findstring n,$(HAS_CHECKPOLICY)),echo 
>>> 'CONFIG_XSM_FLASK_POLICY=n';) \
>>> +    $(if $(KCONFIG_ALLCONFIG), cat $(KCONFIG_ALLCONFIG), :)
>>
>> Nit: It would be nice if you were consistent with the blanks after
>> commas in $(if ...). Personally I'm also considering $(if ...)s the
>> more difficult to follow the longer they are. Hence for the 2nd one
>> I wonder whether
>>
>>     $(if $(KCONFIG_ALLCONFIG),cat,:) $(KCONFIG_ALLCONFIG)
>>
>> wouldn't be easier to read.
> 
> How about:
> 
>     $(if $(KCONFIG_ALLCONFIG), cat $(KCONFIG_ALLCONFIG);) \
>     :
> 
> .. instead, as that would be more consistent with the previous line,
> that is there would be only one branch to the $(if ) and no else, and
> thus probably easier to read.

Oh, sure, even better if that works.

>>> +.allconfig.tmp: FORCE
>>> +   set -e; { $(call filechk_kconfig_allconfig); } > $@
>>
>> Is there a particular reason for the .tmp suffix?
> 
> Yes, .*.tmp are already ignored via .gitignore.

I see. Could you add two words to the description saying so? Or
maybe even just a post-commit-message remark would do.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.