[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/6] arch/x86: rename debug.c to gdbsx.c
- To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 28 Sep 2021 22:09:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YoszqKLQEyHUcm4Qjqr/BlfgU6gwos2Ob3tY8yPqMuA=; b=l1I7YPyuTDze4PDJicBjPrbWk0Vgj4pwEymQsYtn6TVHNp1HLDd63Cu6Ee6jPplhhtvEkoqrD2+QdJGa2wDTzsIeqaOe3mzaJLZtLIykEmNwCX35PmJT7stZ71v4byWL38Ic8FN0ulOvnr0HfmkyUmyoUMGUnVl9OS/G26yLOvCBI0+vExoN4OYNiin18LDwoo8bey4Vs+IR2PA6+oc56SpvvBvOCMCZvqc3MstINafZ6z8kSiDMqntAOcCXqc7nBB25Lo2y45vJQjAbGTkRI2TLD8fwNN3n0Si1iJdrKw9IG1Xb+cHpIj6peWrk5Q57EoE61cH2IuH8FlIBxhWyaA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F2tdrNspkSHjGtq4iUAA7KtTEoz0eT43JFEcUVZ0cI1rhOdlxSnjjEd+G1/4d/HeSOOoreckMN6fMn8fXNaj+4yF1h37FACtRpgLKy9nBl1wH1FyLEabZJrBDlZwuHSp44tzUoeg4mayn7PgXlq1PfAE2Nx6XKA5SkvNpRsvFH6QxKCGy8kb2hMFazi8HchvHP62m7LRbRc4QEcWpJiNDXZ0tA2seA7sMqRWwzoqOb5DCKz0Jq+2ULBArB9J/vjOmMi0VmDbU2t5MOWgo7gTeY6GJnYQQwJUsIC5Sdpzr13mH1gg6K6LhuU3ozbWTMpKR2ahuUkPvWTHdpj0+d9EwQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, "George Dunlap" <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 28 Sep 2021 21:10:29 +0000
- Ironport-data: A9a23:fz/Xd6CCj2kXOhVW/1zlw5YqxClBgxIJ4kV8jS/XYbTApGsl1D1Wz GcWUT2HPvaPZDD3cowlOY2zp0tQvpLQmt5nQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX9w00I7wIbVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/0BTVhd9o6 fV0mKPpSRgZP6KPuugtakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFh2ds3ZwWTJ4yY eJeNSZubw7EZCQQGX0wIYsjl92M2nPWJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv GTL+yL+GB5yHN6CzTuI9Fq8i+mJmjn0MKoYE7ey57hnm12Xy2kaDjUZUFK6pb+yjUvWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS1gaJzabF5heDMUINRDVBdd8Oudc/QHoh0 Vrht97tCDpm9qCbSHeB7bqKpBu1IyEeKWJEbigBJSME/NvLsIw1lgjITNtoDOiylNKdMTP6z i2OrSM+r64OlsNN3KK+lXjYhxq8q56PSRQ6jjg7RUr8sFk/PtT8IdX1tx6Ltp6sMbp1UHHan SQelNG/zNkjMsiNixyMT6YvEIGQsqPt3CLnvXZjGJwo9jKI8nGlfJxN7DwWGHqFIvroahezP haM6Fo5CIt7eSvyNPArM+pdHuxwlcDd+cLZuuc4hzakSrZ2bhPP2ChzaUOK02npnSDAeolkY szDIK5A4ZsAYJmLLQZapc9BjdfHJQhknAs/oKwXKTz8itJyg1bPFd843KOmNLxR0U99iFy9H yxjH8WL0Q5Dd+b1fzPa94UeRXhTcyNhVc2q9pMMKrHcSuaDJI3HI6SKqV/GU9Y595m5a8+Sp i3tMqOm4ACXaYL7xfWiNSk4NeKHsWdXpnMnJy08VWtEKFB4CbtDGJw3LsNtFZF+rbQL5actE 5EtJpXRatwSG2+v02lMMvHAQHlKKU3DafSmZHH+PlDSvvdIGmT0xzMTVlG0qXZSXnbp75tWT n/J/lqzfKfvjj9KVa7+QPmu00mwrT4anudzVFHPOd5dZAPn940CFsA7pqNfzxgkJUqRyz2E+ RyRBBtE9+DBr5VsqIvChLyerpfvGOx7RxIIE27e5LewFC/b4mv8ntMQDLfWJWjQBDHu5aGvR eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRC7/UfxrJQtQasd FiI/91WZeeANM//SQZDLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIeIsYo0/w OontMoH0CCFi0InYoSckyRZ12WQNXhcAa8pgY4XXd3wgQ0xx1AcPZGFUn3q4IuCYslnO1UxJ mPGn7LLgrlRyxaQc3c3EnSRj+NRiY5X5UJPxV4GYV+IhsDElrk82xgIqWY7SQFczxNm1eNvO zc0ax0pdPvWpzo41tJeW22MGh1aAEzL80P8/FIFiWnFQhT6TWfKNmA8Zb6A8U1xH7iwpdSHE GV0EFrYbAs=
- Ironport-hdrordr: A9a23:btn9bKi4xDmZjXTRjIUItzvjO3BQX1N13DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3I+erhBEGBKUmskaKdkrNhQ4tKOzOWx1dATbsSkbcKpgeAJ8SQzJ8n6U 4NSdkZNDS0NykGsS+Y2njKLz9D+qj+zEnAv463pB0BPGIaCdAT0+46MHf9LqQffng3OXNTLu vk2iMonUvERZ1aVLXAOpFTNNKz1uEj2aiWLiIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7XjoyWsllP73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhMF2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYAB89IletiA1HkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooFI5+NRjzUB3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+ FoEYX1+OtWS1WHdHrU11Mfg+BEZk5DWituf3Jy/fB8i1Nt7TZEJgojtYwid047hdcAo8Iu3Z WcDkxq/Is+BfP+I5gNXNvo7KOMexrwqCn3QRavyGLcZek60kL22uvKCYoOlZaXkbwzvdYPcc f6IR9lXVBbQTOmNSTJ5uwRzizw
- Ironport-sdr: wqRDboxWTUxU/Xm7MitI1O1eFmfu5R0YIXYI7CMAxS7HMw+19Gwvw/oIGH2bApfe9aorVrd9vw oct0oFBo1aCarKmHv/rjlNbMWkMqnzMHKmGRmhNTBDmg1bu6AELa9tfqmvskkJRhYbTnR7g/iS 28ZoLVCURPUzpGGvBzOkb2F1hJZ1Q2eL/r+kQZkUgSj6u5iVJJ8RLei1z9PjdrpB+yD4nut3gM kPapDh2ELAV8JCrXaSJOHfV2Q/ZaDOJhTYBTjP1IS24a3s0LR3ACg+VWOFADgW7QdQaWlB8rC4 zC5u0OeWQzQJISKy0ZRFEJKo
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/09/2021 21:30, Bobby Eshleman wrote:
> diff --git a/xen/include/asm-x86/gdbsx.h b/xen/include/asm-x86/gdbsx.h
> new file mode 100644
> index 0000000000..473229a7fb
> --- /dev/null
> +++ b/xen/include/asm-x86/gdbsx.h
> @@ -0,0 +1,19 @@
> +#ifndef __X86_GDBX_H__
> +#define __X86_GDBX_H__
> +
> +#include <xen/errno.h>
The errno include wants to move below....
However, you need to avoid latent build errors based on the order of
includes. I'd include public/domctl.h which will get you both domid_t
and struct xen_domctl_gdbsx_memio.
> +
> +#ifdef CONFIG_GDBSX
> +
> +int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop);
> +
> +#else
> +
... specifically here.
~Andrew
> +static inline int gdbsx_guest_mem_io(domid_t domid, struct
> xen_domctl_gdbsx_memio *iop)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +#endif
> +
> +#endif
|
