[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/6] arch/x86: rename debug.c to gdbsx.c
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Sep 2021 10:09:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=27xD78VhI9s2N/437ueyYiX2G7LUxR9hoJJ4q60h99g=; b=RSLTBTBnv5eUl51blbd3jw/uNNZv/OJgtsjrdOwsj9Jlyr7iLO4AOOzqZjtAZVd2yum7FxjM8K7ecuuTCdrxELdRbrpKREViihwz5vsD3yojZw+iUCeUeoe218G63ebbjMsimL0IDEYS/1xjMTmMWpIhZq79QQpDKskpcTUyHus0yjJaQjvXntRbL/S0uE3cWq5IaGXAekHioOu45RIGatkdnvPSry8CTHhjuitMUSM+2CkGFbP+g+DB71bTrLxlRy5umf981EutXrG2q+HONjqLN2uUBmrRGBPgChyC4CaLA5LYNZXCgLmHypuWnXNrhzJjFCGonnskQ8j+KmVwxg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XoPL0wZU7mLL6cE51dt9lIm8MQSH4yj6zqIzgkpG5GEXh22wfKDYSRCSSaSu/NT+Kmx+i94u1JsXnBhuoXxcw+iS5QN9XdmgfbTg9yOZFpf8QJLd+xqURVTVVFSEam4VkscKCSrV4wlV8zmp9itOlHzodivq9dwgYNfO2TC5MryHlVvaGAju255XFvu14IWmgZB0Y2tvAp9xaP9kiAqJ4l9YUytq/UvC22L2v1+dQ7bDMWnCgUF5TzAkyckaZbp829V6qdD6Q3h1YPk81spO+jZvwZqMKXwOllcAAzy8pt80UAausBlPD7BV201WSKoonJis0sjSLtNlAQH7wFAN+A==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 Sep 2021 08:10:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.09.2021 23:09, Andrew Cooper wrote:
> On 28/09/2021 21:30, Bobby Eshleman wrote:
>> diff --git a/xen/include/asm-x86/gdbsx.h b/xen/include/asm-x86/gdbsx.h
>> new file mode 100644
>> index 0000000000..473229a7fb
>> --- /dev/null
>> +++ b/xen/include/asm-x86/gdbsx.h
>> @@ -0,0 +1,19 @@
>> +#ifndef __X86_GDBX_H__
>> +#define __X86_GDBX_H__
>> +
>> +#include <xen/errno.h>
>
> The errno include wants to move below....
>
> However, you need to avoid latent build errors based on the order of
> includes. I'd include public/domctl.h which will get you both domid_t
> and struct xen_domctl_gdbsx_memio.
public/xen.h should suffice as ...
>> +#ifdef CONFIG_GDBSX
>> +
>> +int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop);
>> +
>> +#else
>> +
>
> ... specifically here.
>
> ~Andrew
>
>> +static inline int gdbsx_guest_mem_io(domid_t domid, struct
>> xen_domctl_gdbsx_memio *iop)
>> +{
>> + return -EOPNOTSUPP;
>> +}
... for struct xen_domctl_gdbsx_memio a forward declaration is all that's
needed here.
Jan
|
