[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 7 Oct 2021 10:05:28 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IQildSs5R9Avr2U1TPosDlRvcDgGAd5+zSEEpLXIeks=; b=Z1jPMDkj0ybPpBKB5vqE41UVqQhYR6R3r6Wjc8/XeATl+bbBw9EH1iTIf+HbXUZFFpYJ2FV/MdPuzdI64o4TJiJ/PnjFGzecDuAcjB2Ceo/FECvyCF4IdoUqwsdg5673jTFgA1HWJIBlFvLksZdUpFaWhuk9KoG/JLXbsZ1t/j8MVwUyZrAWcbiN6p/UbzdDR7uib2s2naPCX6FHPovXCwGawu6R/ZChgAIsTishSNXn5CQ9PoXKm7BYHK39Dgzk55x4dXwzp+SKQCFv09bwvTwu4+4VeMTIbhH76bKhaCK8daOq5RE7r495cTCQx8dsikorD8dzzJ0Tl3ie543HRw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4+eusjb+iKn8zgxPn+MlpABP/YvcnlTKuQCdaFYx/bmqb4O8UGSopl2z8hEnJuefTwSqBDfqlqlGYcd1NMcvNOCnPE5nu5C/3WaWYsw6xwZNvvD0j/ZA9Cm1BEty5/0CBxebajDOEfbvz4mC4RzpWx/P4/WMmTqGutZTEg+ZVQo9n28r+gNAlatRVsy1ZhgXAZtaCleCcnnaJFn87OLBNx57T32HPqx76AfQNmXeJ7Ufyo9rplo+teE2niWQVPdRmSeZLnsrB8qMBC1l2buUB9OLdhCMHZ0H94Nud2J5VacPp3VgJNx6Q9iQBAPhayd85OhV8JhRPhbTEDOFM3ygg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, bertrand.marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 07 Oct 2021 08:05:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.10.2021 10:02, Michal Orzel wrote:
> On 07.10.2021 09:59, Jan Beulich wrote:
>> On 06.10.2021 12:58, Michal Orzel wrote:
>>> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
>>> indicates whether the platform supports vPMU
>>> functionality. Modify Xen and tools accordingly.
>>> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
>>> definition in sysctl.h which wrongly uses (1<<6)
>>> instead of (1u<<6) and does not follow the standard
>>> of using separate macro for a flag field.
>> While adding the u suffix is fine with me, iirc not introducing
>> _XEN_SYSCTL_PHYSCAP_vmtrace was a specific review request at the
>> time. I would similarly ask to avoid introduction of
>> _XEN_SYSCTL_PHYSCAP_vpmu here, for it not being consumed by
>> anything other than XEN_SYSCTL_PHYSCAP_vpmu's definition.
> Ok I did not know that. I thought we should stick to the previous standard.
> Is this something that can be fixed on commit or should I send
> a v3 only for that?

You may want to wait for further review feedback first, especially on
the tools side. Considering adjustments to subsequent patches I would
think re-sending will ultimately be better.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.