[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag


  • To: Rahul Singh <rahul.singh@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 7 Oct 2021 15:08:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4cGeZN4m4w5ILM164lNqYQPwXRnKOQN03gFaf3Hb4wo=; b=jWre/a1lFaPFEU1/VGHVHR2rsT13X5kmit1YGwVUUBbhNr2tdepJTvYxl8nGuFA94dj8S5TRtdszXEfzks1I7wQX6bHnZstjEmErA2mXE6EcREGYQEwXRqhlFqB4t+XtRpE6adQs7ak2wzmPbHw2QVDmx5uxn0OpsHgdjOmR8qk21NCd/hpBZnue21U6xT3Hr39cPqADV+CUKLL1grOJWX6ecNy7OM3BiUW8znzRkunxvvJhhcSmrnckQ6IWIqg/mcG+VqwJMplsMq2v8SOUAnkNcrTGPeLKfnrDuvwqcbQv3/mx2hpV06WqNSUmoo55HsHw/Oy+8tj4nVxgOzFu3g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yb/gwZYPWqAG8IEMDD5kkWI/Lk51VCW3njjXfit08phzJWwkMkeu2m423x3413KdVG+jzNFq4BeyoDDeOp/Lc2XbwNaLaUDHLRyj+uSgY6CxCOtCErae8gCKUPh9YFiSr90D2sEDou+zio+XUlWFSiVZ4OlxfduSxSbxmpxpfjZf7IuHptn9AGNIfokUmOpnzSMn9ySl/sC489qv9qsmEWl6L/OOgolKXsH6YZejZwBCP4kgu1SUslrsQyno1SDKQoKGHrDiaux+3mLljuePB8rsUislR/A8unNNGqAVGtgORhESOcLkuqbO8bKtW19VJ+rG82GIp0ZyW3mYhMpCVQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: bertrand.marquis@xxxxxxx, Andre.Przywara@xxxxxxx, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 07 Oct 2021 13:08:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.10.2021 19:40, Rahul Singh wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
>  #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
>  #define _XEN_DOMCTL_CDF_nested_virt   6
>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> +#define _XEN_DOMCTL_CDF_vpci          7
> +#define XEN_DOMCTL_CDF_vpci           (1U << _XEN_DOMCTL_CDF_vpci)

Like said in [1] here I similarly don't see the need for two constants.
Preferably with the former of the two dropped
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

[1] https://lists.xen.org/archives/html/xen-devel/2021-10/msg00266.html




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.