[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
- To: Rahul Singh <rahul.singh@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 8 Oct 2021 19:06:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQhlx4wtZb7Wi4rVykfIpQlZmIumaYt5vzYfpm3VwZU=; b=Ss2bn8Kvnz9T+gxM0psSiqCvxj7aucopoUBRtLRLVi1m+hnIeeej8hgxez5Z+TAgKqj4GHwSzDosUGxKIbdcXEuWsqJQUYdVKS7Y9uQ5iCgRMnhD3kPnNP4EExCVT9pW8dTG7NiK6y8Egxf1I2MwB79tK97kAI/1Z2zQnCl5X4hF+EKG3nAj8oSK3Rlzk1h4tSAtpsDyrVYSe1X7YJPq/ySN0HGca00o+o22ILRLALA/l99qXc9Qs2jIk7HkdRQl2MuNieBQJEcSJsbBerCq5fa3DNNHkr24YzuiUspVsJAwtkuD1s0gPDPmTH19KmteBv50HNBAprMTuJqc0jwOfA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUcV5oWzRcjqrSFXxjKYaNz6e9SYez2feHJT+S+lyD9t9K3D1bfJc6Ctw/ikaJVuV/Fi0vInlE//GVzsPOP4nd8cbO+37j/JPWIFZ77NnDdYnIjgFSHd8iNc8pFMj2IMOZafyXgTH2racJiVkINBd664vSUKc1VXhtbD1uUDqICBXReMWL7yu6aIOQO1sFpug85ONDpm8e9ek3pw3ZkZM01fS3nLE7Y4OEY54axE/zMrTtICs06QTTbs3boczSY2UhQ3ppygEcMAukje+cktMLar8gBYvO/5/eK+aJ2rW3rYISsui3p6ffQ7YU+meEFfqRblBFYmeiK6RNzYVYtpSg==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <bertrand.marquis@xxxxxxx>, <Andre.Przywara@xxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 08 Oct 2021 18:07:34 +0000
- Ironport-data: A9a23:8FoH2q1+ak3QcpmHBPbD5cR3kn2cJEfYwER7XKvMYLTBsI5bpzUHy mMZCmCBPfnZYmGmf9x1a9/k8R4D7cLRz9FgTVZvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7w75h2OaEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhh8x7y PtLlseKZSx5H5Xzl8MtbAcCHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t25kTRauHP aL1bxJAMBjSYiwSE2sQFawEls2hwSb+eh1x/Qf9Sa0fvDGIkV0ZPKLWGPPTdsaHA/1PjFeHr 3jP123jB1cRM9n34TaM7H+EnOLEmiL/HoUIG9WQ/PNwnEeawGBVDRQMTEa6utGwkEv4UNVaQ 2QO8yozqe4p9UqkTvH0RRj+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ l6Wnfv5CDp3qrqXRHmBsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5LLqmxidHkHCDq9 BqDpiM+mrY7gNYC0uOw+lWvqzCxopnESCYl6wORWXiqhitmYKa1aoru7kLUhd5CJouESliKv FAfhtOTqusJCPmweDelGbtXWuvzvrDcbWOa0QUH84QdGyqF42Kpfa5Ww2pECGw5E/47dhjZX 1GJtlYEjHNMB0eCYahyaoO3Ls0ly6n8CNjoPszpgspyjotZLlHeo3A3DaKE9yW9yBFzzfFX1 YKzK57EMJoMNUhwINNarc8z1qU3jgQ32G/eX5zyyxnPPVG2PyXOEeZt3LdjdIkEAEK4TOf9r 4g32yiikUw3vAjCjs//qtV7wbcidyhTOHwOg5YLHtNv2yI/cI3bN9ffwKk6Z6tulLlPm+HD8 xmVAxEDkwSk3yafeVzSMBiPjY8Du74k9hrX2gR2bT6VN4ULO97zvM/zibNtFVXYyACT5aEtF KRUEylxKv9OVi7G61wggWrV9+RfmOCQrVvWZUKNOWFnF7Y5HlCh0oK0L2PHqXhVZgLq5JRWn lFV/l6CKXb1b185V5i+hTPG5w7ZgEXxb8orBxGWfYIJJBm1mGWoQgSo5sIKzwg3AUyr7hOR1 hqMAAdeou/IooQv98LOi7zCpICse9aS1GIDd4UCxbrpZyTc4ES5xopMDLSBcTzHDTum86S+f +RFifr7NaRfzlpNtoN9FZdtzL4/uISz9+MLkFw8ESWZdUmvB5NhPmKCgZtFuJpSy+ILogCxQ E+OpIVXYO3bJMP/HVcNDwM5deDfh+oMkzzf4K1tckX37SN65pSdVkBWM0XegSBRNuItYogk3 f0gqIgd7Anm0kgmNdOPjyZ18WWQLyNfD/V7589CWIKy01gl0FBPZ5DYGxTa2pDXZoUeKFQuL x+VmLHG2+ZWyH3dfidhDnPKx+dc28gD4UgY0F8YKl2VsdPZnftrjgZJ+DE6QwkJnBVK1+V/Z jpiO0FvfPjc+j5pgI5IXny2GhEHDxqcoxSjx1wMnWzfbk+pSm2SczFtZbfTpBgUozBGYzxW3 LCE02K0Az/lcfb40jY2RUM4+efoSsZ891Galc2qdyhf80LWvdYxbneSWFc1
- Ironport-hdrordr: A9a23:VGLZHKst0n1+E2wou8xji46K7skC4YMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJhBo7G90KnpewK4yXcH2/hvAV7EZnibhILIFvAe0WKG+VPd8kLFh5ZgPM tbAs9D4ZjLfCJHZKXBkXmF+rQbsaC6GcmT7I+0pRcdLnAYV0gj1XYcNu/yKDwGeOAsP+teKH Pz3Lskm9PtQwVtUiztbUN1IdQr6ue72K7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLhCP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4DpE/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MlkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0tI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa 1HENzc3vBLalmXBkqp/lWH+ObcG0jbIy32BnTr4qeuon9rdTFCvgolLfUk7zU9HMlXcegD2w zGWp4Y3I2mAPVmNJ6UqY86MLyK41f2MGfx2VSpUB3a/ZE8SgDwQqHMkcEIDcGRCdY1JcgJ6d n8uG0xjx9FR6upM7zX4KF2
- Ironport-sdr: /aKyFA+IsRvFbZCdxq5uXCkhx174BsK31SvQszqZD6oYSAcpuGRPaUqsp4Q11JulC61/S/lmzr 3X5/J+k8L453g8nmF43x8Az5dtfDkHPVOERmDRVgXqiOHh0SCKA0ee5UwwNwlx+a6tB+LNHLX8 KmgPbYXv8oJmd4jEyLn4QvmFBs/i4Ez9rQ36y6K++IXnBd5VLKjb3JLNyEYXzMGxS77FwFyavf Ch1As9CGuTNtU9D0Z62QebaS7mZk3ukx/k5v7SwKYCy+wiwbXOCF2agadcIOWlfPZmFuyOEp6A RA0t7CCIVVClw8m6mIqh5ixs
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06/10/2021 18:40, Rahul Singh wrote:
> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> Reject the use of this new flag for x86 as VPCI is not supported for
> DOMU guests for x86.
>
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
I'm afraid this logic is broken.
There's no matching feature to indicate to the toolstack whether
XEN_DOMCTL_CDF_vpci will be accepted or not. The usual way of doing
this is with a physinfo_cap field.
This flag needs using in Patch 10 to reject attempts to create a VM with
devices when passthrough support is unavailable.
Ian, for the 4.16 release, this series either needs completing with the
additional flag implemented, or this patch needs reverting to avoid us
shipping a broken interface.
~Andrew
|
