[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Thu, 7 Oct 2021 15:29:47 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xMbvtsafk8HUbGV2INpIWlkzHN5DRDADVvr+1fMg1pM=; b=JfPyKIY8y7eIcBXlDo4YaIIAhTjjQo9evfAQZwk6jNWek9OqZqRM72QB/fTW3vTd1M3rZJaqnzoh1IJsUoIMhg9jsMm8BV6BN8htL7UEOpR6lycqhZSiU8ERmUY5j76wH3K1iozAnlWPItBlZq1PY1l4fSZ4fnxl4jUbpeILl406KIvQkx1FUi3JXnwlHmxhLfnLXZ1Gp6LiLtX7ZQnHDMhGzDAa3TGzMROzKupfwv5sz4oin6+RlTuBVLIUvdUfwRryPB8ub/6hD4AnOnM48Z67NPPNSulh3cSlDMOp+IBpPGpZUV7YuFae+nrGRVQXQiZ5D5qiLaInC9HL/My79A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/rm0oIVXBPe8qB+Oghf+1kSiSCt+7CrQM4KzUR4WrqUKAkJuUOdWOP4VLbgeAaRrEyf20Mm4TqeQQyDL0un/f3lLmGfZpEg3ti89+WBRXGaFdvWQCzLL1SITNv+sabsD1CE8JYDUcPzTsvza4v1xHQnpySd5Sw4rOfggwjA8UqvXuN7P1xeGMwGH1SHIQr3To38LXK3ZqkTQhMKL4bUX7HIoq6KWrwNOJhwshPGR+7ZtOiTUwCI7wLbQ0DS7V6iJsXiUVNGE+G52RDUBB0Mv5RxliT40VcUrGv4HibKwTKfWbA5YaOgDPCm0AUi86tjEM4iwx1czId8EJ8/3wJi0A==
  • Authentication-results-original: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
  • Cc: Julien Grall <julien@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 07 Oct 2021 15:30:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXutl6z4iIfi6+uESKx+Wr4ZB/gavGQpyAgAEa5QCAAE0egA==
  • Thread-topic: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

Hi Ian,

> On 7 Oct 2021, at 11:53 am, Ian Jackson <iwj@xxxxxxxxxxxxxx> wrote:
> Julien Grall writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device 
> tree node in libxl"):
>> On 06/10/2021 19:40, Rahul Singh wrote:
>>> diff --git a/tools/libs/light/libxl_types.idl 
>>> b/tools/libs/light/libxl_types.idl
>>> index 3f9fff653a..78b1ddf0b8 100644
>>> --- a/tools/libs/light/libxl_types.idl
>>> +++ b/tools/libs/light/libxl_types.idl
>>> @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>>>      ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
>>>                                 ("vuart", libxl_vuart_type),
>>> +                               ("vpci", libxl_defbool),
>> I have posted some comments regarding the field in v4. To summarize, 
>> AFAICT, this option is meant to be only set by libxl but you still let 
>> the toolstack (e.g. xl, libvirt) to set it.
>> If you still want to expose to the toolstack, then I think the option 
>> should be outside of arch_arm. Otherwise, this should be moved in an 
>> internal structure (Ian, do you have any suggestion?).
> If it should be in an internal structure, probably the libxl create
> context.

As Stefano suggested in another email that we can remove the vpci option, if we 
reach to conclusion that we need vpci option I will move it to internal 
> But I'm not convinced yet.  In particular, if enabling VPCI is
> necessary on ARM for hotplugged PCI devices[1], then there has to be
> a way for the admin to say "while this domain may not have any PCI
> devices right now, I may wish to hotplug some".  That's what the
> "passthrough=" option is for.

Yes I agree with you VPCI is necessary for hot plugged PCI device and once we 
implement the hotplug in future we will use the passthrough= option to enable 


> See my other mail.
> [1] I think this is all true even if PCI hotplug for ARM is not
> currently implemented.
> Ian.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.