[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/PV32: fix physdev_op_compat handling
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 11 Oct 2021 15:06:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BXvcUP+XqHV5AjwM1QEKFi9EuiUym3Ks2KKWcaWUKaU=; b=HC944laBOhycFE2dE9q8JymMFbZu+hOJ07OnwKoqGXlFlZyPZp68IhNgZ0PMaz1mlrC7D66et+pO5NNod9Bp4oxx0OWNGp/sh+TvcStCjfK4Xy59r30RurwGVmpvwGKO/Tqi3bEHIGDRPcB2w2LFdkQ5vcuk7lJs1Xv1JFsfM3EiqprdSiyVi5e2I/gqdDN5o0zaL9zdmKKlGMpUyNFb5k1/B6ButsMTpzMz/4MKQQEXMWIGXSGhx/dq+/Mgso7y0+asXQ5cRwQtduFQ7zfVUXEGqCEeZWVVP9YHN2eVMEICAsLvYYId5mOoVYUgxX9efW+o9GEMLeeut7tXSU/QMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ed/yTviysB9o3KrO7odDu0jv2dOyiFUzJ/yCs8BFNLIAVuVa+TQZiCZaBKnpTp817RXSCNCFj0KQNYFb0K4JmG+pfvPxfkbqaQZnqL1HTyfoJab79kInpk9AP0yjZlXGQdexNJ5Q8XOOabDXvF6ZgjfOxVGaKpdYFpZ/8GYgZTCkChAI7K59CX6ggpfTq2/wb5pwfT5ndofnvIxKlqEo9bvq2v2fiutC+nfxXH4J+YOPUUKceLfdY5K4H7c5gAo6bf1I4I898a2p4xDrn+GKY2GtW7P/rOHfVW3HY3BTWhVVrhitaLb+TRrlTFqwQkHQ8p2fNhcgnjDEPtNKZfeb1w==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 11 Oct 2021 14:06:47 +0000
- Ironport-data: A9a23:PJnCCKPYsqvdb47vrR1DkMFynXyQoLVcMsEvi/4bfWQNrUoi1TcFm 2dOCD3SOPmKMTDyfI1wbozj/UkB68XQztNiTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us6w7dRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2yR3M1Xz /IOjrypER8KE4HswP0vTBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgWlv25wVQKu2i 8wxeDhBSRGcUkN2Ng0FN58TxbaFmmO4bGgNwL6SjfVuuDWCpOBr65DvOtfIft2BRe1Og12V4 GnB+gzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQMDDUGWF39puO24nNSQPoGd RZSoHB36/Fvqgr7FbERQiFUvlbdpl0Bfd13UNYa8VmV6Yf4w16ANHcLG2sphMMdiOc6Qjkj1 1msltzvBCByvLD9dU9x5ot4vhvpZnBLdT5qiTssCFJfuYG68d5bYgfnF447SMaIYsvJ9SYcK txghBM1gKkPloY13qG/8EGvb9mE98WREFBdCuk6WAuYAuJFiGyNO9zABbvzt68owGOlor+p5 iVsdy+2trFmMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8lfxc4apldIGO3O yc/XD+9ArcIZhNGioctMuqM5zkCl/C8RbwJqNiFBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WnOnOJrtVJcQxTRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WZQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
- Ironport-hdrordr: A9a23:AJHNrahvEm5o/J5rGgxqOnjVyHBQXt4ji2hC6mlwRA09TyXPrb HLoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SOTUO0VHARL2Ki7GO/9SKIUPDH4BmuZ uJ3MJFebrN5fQRt7eY3OEYeexQouW6zA==
- Ironport-sdr: 55DyMtZ9yJS6a6fqweJtQ9kQ85bbpRD43oKRayC5y6lPaIn4dSMwJ0mM7H9dfV8s9MEC3qbMbQ CJoYv+k37A+zLBcOpzng49LwRFcgNZhtk3e9KhOLdAfhL76SHvoouaEZ5/MYXXk39AmyLrS14U SWRZ0CnV05nwquZd/MzfDfGCcJ6F8nz3By/DWs5uWFocxcoE2aUt6U4p1BeKYr2W6JAnJlhJrC 3JN1C2YV1ESAmaDqRHL9SKNKQMH8J8RwzBWv+qnMBG8jrYlmxVJMjO5iVpi4qSJcYUmbSoXZ81 YxV2Af0pTuKW72ObdWwVfLA3
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/10/2021 11:06, Roger Pau Monné wrote:
> On Mon, Oct 11, 2021 at 10:20:41AM +0200, Jan Beulich wrote:
>> The conversion of the original code failed to recognize that the 32-bit
>> compat variant of this (sorry, two different meanings of "compat" here)
>> needs to continue to invoke the compat handler, not the native one.
>> Arrange for this by adding yet another #define.
>>
>> Affected functions (having existed prior to the introduction of the new
>> hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
>> For all others the operand struct layout doesn't differ.
>>
>> Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than
>> working around it in several ways")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
