[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/PV32: fix physdev_op_compat handling


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 11 Oct 2021 12:06:34 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8D2APnASnPIx2KKHfB9HVWACRoM0oq7S+IKo1fir02c=; b=TF7OJk96LuukVejr+hLnpUcGly5gQV95cbuLF297lBwjqCh/4B3BWNu9Cvrj5O2WZOlZTQ66mlqqH0xMdIMZec3JeF7Kqzv96KT0WdN53RM6jVmifA61GpjLqvPTXO9SjadgIszjx4SDrK0IG7ZenYYHtXC8OJ78VJe6ps6mCR94WIneyc/L1E915zQkVpEH9cZ5kZ6KkTBk14/xDA6A1IaZ3QLzt2K2W1a2SK1zngOJbC1RQ4wX7uAQMDkbzp4EdOTAUWV3hH3hVMAoy0P3WckEwE0Npax26GvwNL5miXva/IDjQI72maf8neu5TekEi9bhoVg89z9tz1eRPJZwKA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbkdnhENPo+0McbGVa+u+XuzxShfU9+csd/+c4AKM9UT8i+eonbQFhv6c24uIdFMdjCggm9GPwZ3YTbJDGBhMwuKIEwj8biqIhzXO0quLSC4weTUlFRdkS78+/30bHToL8N8KkVs0Ltpzf8XtBExbadnpohmFDolLEsWL0N+hEjjAPgCi0D/mHG7abm/6dJv6Qy89hUkyUPH+c/AznAi/6L/LeVBSBuCLs7JHiI4b/+NDumRzYDMT07bPA9mMfHkf/taMZJHDTPB8TlNUk54k9x5lW48HNsQPZPGeRk9iGsPgSOOwXt16ZfZ2n5lczwJrMPpYv4ElG1L6FN1+DHqGA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 11 Oct 2021 10:07:38 +0000
  • Ironport-data: A9a23:UT1ybK8CPKarkUt4qE7kDrUDW3mTJUtcMsCJ2f8bNWPcYEJGY0x3z TMfXmuEaPiIa2bycop/OYmz8xsHuZTUyNFkGVA4qnw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg29Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgux u8SmKXpEzw1fYfSlNs3CxtfGg5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgGtr2ZgeQZ4yY eIoTgVmMBT5ZyYVPw0NDKojvc3v3nfWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc QpOoHNo9PVsshzwJjXgY/GmiCGKhEExYoMKKPF5wh+B9YCM4QGQKVFRG1atd+canMMxQDUr0 HqAkNXoGSFjvdWpdJ6NyluHhWjtYXZNfAfucQdBFFFfu4Cy/+nfmzqWFo47eJNZmOEZDt0ZL 9qilyM5m6kIxfAC06G27DgraBr9+8CXEGbZCujRN19JDz+Vhqb5N+RECnCBtJ6sybp1qHHb4 RDofODEvYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmoldBYxbZ9dJWGyC KM2he+3zMQJVJdNRfUmC79d9uxwlfSwfTgbfqG8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M r93aqO39vmoeLSmOHeIqtRPcQliwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4 je2XUow9bY1rSyvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
  • Ironport-hdrordr: A9a23:QbmanK0TeG5cmSgpRd/BtgqjBSFyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdL3AYV0gj1XYDNu/yKDwGeOAsP+tBKH Pz3Lshm9L2Ek5nEPhTS0N1E9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXkHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMW9yV0qp+1WH/ebcGkjaRny9Mw8/U42uonlrdUlCvgklLJd1pAZHyHo/I6M0r9 gsfJ4YzY2n46ctHNVA7dw6ML6K41r2MFvx2VKpUCba/Z48SgbwQr7Mkf8IDbKRCdE1JKVbou W2bLofjx9rR37T
  • Ironport-sdr: ytzq53HyMLTHd9wGv515HdPcRtv02HE5vmJcwOs7k4TNYto/VkXzhzWI/sbWSpQ5h3Ph1w8slB 5JbUomL7DhEhF2AINlc3cjbH0sNmDICeeYotf715+hd91MPTabKqfO3kmmCRmxKO84yOHYhpyY 1VkLGYnWMwWvU3IRjsHHZuU1ezEsvoHu1enQlq5JD3LXU3GeDwSGM26hjzOE1TnYBtjc5ABN+f SfPIb35wWQ79/mtWDKhpRaBZyBnzSkEKLa7W8QDQGg2RIUWSDbq6X44Rb0XZ5A0ONSK0w+h9Z3 rK0ypo1U6HO4+CrmQ8D2tqBP
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Oct 11, 2021 at 10:20:41AM +0200, Jan Beulich wrote:
> The conversion of the original code failed to recognize that the 32-bit
> compat variant of this (sorry, two different meanings of "compat" here)
> needs to continue to invoke the compat handler, not the native one.
> Arrange for this by adding yet another #define.
> 
> Affected functions (having existed prior to the introduction of the new
> hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
> For all others the operand struct layout doesn't differ.
> 
> Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than working 
> around it in several ways")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.