[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile by introducing build.mk

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 12 Oct 2021 10:06:12 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ekSHirgG27bQ0QufMpRD9KcZLOUJTkvIRdDFX8JC+/I=; b=M3QVcGZEhgZmGdmhMHaGCPDoaf8AjQF7JtO4cCQoaYGKz5rLRXr6yQubjMJqE9hVdnMAfUz7G5mXo3FbFDNg/j8ILrSNo5P4ZJ3v+FAOH3sv9LxtMY3KIfBpoFMOTwTLDQRBYCH83jYIvhfKFXsrh1ZXdP1GCIeLyrvMht3fMPWqza7C7O8TIMEvyTtql4wtJHtatw2q/W9+u4/1Bh+F6HnKysr8/bSzvQl0S+qGd5gZkb8WzJ5usPX/2HeSo5V4bn/ye01snyYGmhbA2JrvzCSyu6Mt+PR9u7XPRvFEC4GCOgEOSWRYFk8bNAc/vdTRX6hv40GWOtRJEP5U21TmyA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFLarFLhQXt+IKAHcdBnxPwN+s/9r9lUXquaOFCNQVg/CwHvG0GjkDX9Bal6Cz8kYJsGg2Eb74yGDKw9bUQJaYFqsRuj8mMhACp7DQ14N5xZcHgBielYQr4hXdDrgfQXCzUBcrV3meS5Dfq0SZBoHe+xXOE572kPbTMyNG7mgaXtI7hssRRzPsnbQk7j3g4iAz4+CzLdDfDlgg5XKPj2daLf3Q+Xvc7D54UM6ar0BJhKuq6uDuxTotQ29P+w7niPSOi602xGb2h0wVdQSOrrEewIIxMdoHktqk6IEvWThHCDLNxArheCe6eXfb9NANCUDp+xBPNcCkwBd792xbnt7Q==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 12 Oct 2021 08:06:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11.10.2021 19:07, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 05:31:08PM +0200, Jan Beulich wrote:
>> On 11.10.2021 16:58, Anthony PERARD wrote:
>>> On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote:
>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>> With nearly everything needed to move to "build.mk" moved, there is a
>>>>> single dependency left from "Rules.mk": $(TARGET), which is moved to
>>>>> the main Makefile.
>>>> I'm having trouble identifying what this describes. Searching for
>>>> $(TARGET) in the patch doesn't yield any obvious match. Thinking
>>>> about it, do you perhaps mean the setting of that variable? Is
>>>> moving that guaranteed to not leave the variable undefined? Or in
>>>> other words is there no scenario at all where xen/Makefile might
>>>> get bypassed? (Aiui building an individual .o, .i, or .s would
>>>> continue to be fine, but it feels like something along these lines
>>>> might get broken.)
>>> I mean that "xen/Rules.mk" will never "include" "xen/Makefile" after
>>> this patch, but the variable "TARGET" is only set in "xen/Rules.mk". But
>>> "xen/Makefile" still needs "TARGET" to be set so I moved the assignment
>>> of the variable from "xen/Rules.mk" into "xen/Makefile".
>> Okay, thanks, this confirms the understanding I had developed; maybe
>> you try to reword this some. What your reply doesn't address is my
>> question, though.
> Which question, there seems to be 3 of them :-). Is it about
> xen/Makefile been bypassed?

Yes, sorry for being imprecise.

> Building anything in xen/ requires to first execute xen/Makefile as this
> is where variables like CFLAGS or XEN_ROOT are defined, and this
> includes single builds or building an individual .o.

Okay, thanks for confirming.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.