[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Oct 2021 15:56:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yoXwDMfAOlFdy+y2EbMVV9zGinpkXLN3E04ealKOO20=; b=gI6IiRbeDeGjV0BiKpHoBuo1UZzpLY6C0s2DEW3uzGwmJQqRFBgsRvX1lfqc9/pXyQYFYNLQJ/t3z6+MlMHQwo8l4PA1cYmlxN2pkSOSCxxYt4R9QfYq7P0k63OemR66m4o2IFT46Q87J58lvesieP3AefHhx4XjO3MqlLiH+Oy5LSaLuemJsaa+VCwQYQX4YV8evqu7g91zEMD2WwimiW1gnK/HdFNe6ijjLLXgblVO2BuuxQXwk0vP26Erlm2sSSmskMBxEyp3kDvYGiUMX007jA5iEb3u/BrnTjjlOY9YtOyO7Wn1KBP4QYyg1aYvzacfXQtfALGgO9ovmdlypQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0j/36qbgZe2OiwSj7T3bMX6UdTh/UeJ9nUPWld1svkww+7bD5/9yju8MAyF8KIo4OQtzH7ahrwk0NBc3/ZnL36LFeQnQQF73u2S/K7/FbYwY4rOFpEmrU5PiQlafagBi7BuZ2GMaa8DtxGH0jAsVtZBhVFE+l4xi0LgrrNphxIp4ehSE5hVK9ehuefhxVglwP/kH6cr5DIPfqJAK3dj1sPyY2/1hRIOwrxKhfozdg6p6mEMmVYWU/+9+zWcna0ILKKrb6dNvdNWI/UUkXMCteiseGZvmEOy1Lv9e/Mo12Uo2WVGWjTQW1XUR7dhIXYLH0QVFP5G13VF57P4xbl8iA==
- Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 13 Oct 2021 13:56:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.10.2021 23:22, Oleksandr Tyshchenko wrote:
> @@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct
> xen_domctl_getdomaininfo *info)
>
> info->cpu_time = cpu_time;
>
> - info->flags = (info->nr_online_vcpus ? flags : 0) |
> + info->flags |= (info->nr_online_vcpus ? flags : 0) |
> ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying : 0) |
> (d->is_shut_down ? XEN_DOMINF_shutdown : 0) |
> (d->controller_pause_count > 0 ? XEN_DOMINF_paused : 0) |
I don't think this is a useful change - you move from a simple write
to a read-modify-write operation. With this dropped again, hypervisor
parts:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
While this has meanwhile moved quite far from the original proposal,
I still wonder in how far Andrew may have remaining concerns. Did
you check with him, perhaps on irc? But of course catching his
attention may be difficult, so no (further) feedback by him should
probably not keep this from getting committed (if no other open
issues remain).
Jan
|
