[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo

On 13.10.21 16:56, Jan Beulich wrote:

Hi Jan

On 12.10.2021 23:22, Oleksandr Tyshchenko wrote:
@@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct 
xen_domctl_getdomaininfo *info)
info->cpu_time = cpu_time; - info->flags = (info->nr_online_vcpus ? flags : 0) |
+    info->flags |= (info->nr_online_vcpus ? flags : 0) |
          ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying     : 0) |
          (d->is_shut_down                ? XEN_DOMINF_shutdown  : 0) |
          (d->controller_pause_count > 0  ? XEN_DOMINF_paused    : 0) |
I don't think this is a useful change - you move from a simple write
to a read-modify-write operation. With this dropped again, hypervisor
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


Will drop.

While this has meanwhile moved quite far from the original proposal,
I still wonder in how far Andrew may have remaining concerns. Did
you check with him, perhaps on irc?
But of course catching his
attention may be difficult, so no (further) feedback by him should
probably not keep this from getting committed (if no other open
issues remain).

If I remember correctly, I made several attempts to clarify in the initial thread. But, I have to admit, not via IRC (I am expecting some troubles with my IRC client last time and I haven't figured out yet why). Of course, it would be correct to get a feedback to make sure that there would be no remaining concerns (as the main concern to use domctl was addressed) or otherwise.



Oleksandr Tyshchenko



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.