[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 47/51] build: Rework "clean" to clean from the root dir
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Oct 2021 11:44:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTirFEo+vHGxZZn50utoGMoRAfbsSSvVAfED9B9MsZo=; b=Q6Pm27ckF2y2U2HkcZ5oDr7ljEAHga2qnMukriIg/XRYpBGBmStxYAnhqcHSqY7HN8SF5ZNOAYM3MKMUyCTBJM+TD+98P8ZDbNRDdln9+Q2yBIVUqFouQS8VfY6drvSLy8zfYCd2lDg9OT50/6RTSU45QNwni0xJI26IDfH8BJBnQ8gRKvq/zLuRELZhgGklPQu5ujV2yMtBmKNmXGx9rQxWWH0IwrEpahuE38bwg2q4k2Q6AFF4MBvzTsPWj5dt+vjr7MuH7Iyc/d1XJW+H7M1NYyHPUrVvk2eyCgpR5nK8E8Ko0pfso3uA/7U8NKDACPqaOnMtpqDp2t3CaVdCfQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVMyuVT/fHsPGlf+sGLMLYcVn52ONQ+Ih4nD7JZm5gGeEiPHe9O5zK6oSoCdg/OLHJpjNRGQXMn1L58qKx3TvrqwqZP5j0zadAqal3boOKAGwH+A1JvOmvPA3hjmZWCTkldgw+ED6BxBq2IN0tA3kOAXukbpM1yS3T+UKCemMdrnb7vMzIKfQuAzDCmgBmiqQ16/Rtn3EXpecLKcMIlqyxcQoYVGKo16DAtwgBA0PmQxxNfnR+ppjOzeP6k3AYRU9BfZYYL1WXcXLXSns6qexWtp8CkGzZEgp/CjhvldgnGnAFsBdPVavwneMxJW04otEl2X87jV0Tyk0hpto3D87w==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 14 Oct 2021 09:44:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 12:50, Anthony PERARD wrote:
> This will allow "clean" to work from an out-of-tree build when
> it will be available.
>
> Some of the file been removed in current "clean" target aren't added
> to $(clean-files) because they are already listed in $(extra-) or
> $(extra-y).
>
> Also clean files in "arch/x86/boot" from that directory by allowing
> "clean" to descend into the subdir by adding "boot" into $(subdir-).
"descend into" (also used in a respective comment) looks contrary to
doing everything from the root now, at least to me.
> --- a/xen/scripts/Kbuild.include
> +++ b/xen/scripts/Kbuild.include
> @@ -98,7 +98,7 @@ build := -f $(srctree)/Rules.mk obj
> # Shorthand for $(MAKE) clean
> # Usage:
> # $(MAKE) $(clean) dir
> -clean := -f $(abs_srctree)/scripts/Makefile.clean clean -C
> +clean := -f $(srctree)/scripts/Makefile.clean obj
Doesn't the comment want changing as well?
Jan
|
